From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE99AC433E0 for ; Fri, 22 Jan 2021 13:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A251B23437 for ; Fri, 22 Jan 2021 13:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727521AbhAVNU2 (ORCPT ); Fri, 22 Jan 2021 08:20:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:50592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727381AbhAVNUT (ORCPT ); Fri, 22 Jan 2021 08:20:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BC1AB23428; Fri, 22 Jan 2021 13:19:36 +0000 (UTC) Date: Fri, 22 Jan 2021 13:19:34 +0000 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Andrey Konovalov Subject: Re: [PATCH v5 3/6] kasan: Add report for async mode Message-ID: <20210122131933.GD8567@gaia> References: <20210121163943.9889-1-vincenzo.frascino@arm.com> <20210121163943.9889-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121163943.9889-4-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2021 at 04:39:40PM +0000, Vincenzo Frascino wrote: > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index bb862d1f0e15..b0a1d9dfa85c 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -351,6 +351,8 @@ static inline void *kasan_reset_tag(const void *addr) > bool kasan_report(unsigned long addr, size_t size, > bool is_write, unsigned long ip); > > +void kasan_report_async(void); > + > #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ > > static inline void *kasan_reset_tag(const void *addr) > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 234f35a84f19..2fd6845a95e9 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -358,6 +358,17 @@ void kasan_report_invalid_free(void *object, unsigned long ip) > end_report(&flags); > } > > +void kasan_report_async(void) > +{ > + unsigned long flags; > + > + start_report(&flags); > + pr_err("BUG: KASAN: invalid-access\n"); > + pr_err("Asynchronous mode enabled: no access details available\n"); > + dump_stack(); > + end_report(&flags); > +} I think the kernel test robot complains that with KASAN_SW_TAGS and HW_TAGS disabled, the kasan_report_async() prototype is no longer visible but you still have the non-static function definition here. So either move kasan_report_async() out of this #ifdef or add the #ifdef around the function definition. It looks like the original kasan_report() prototype is declared in two places (second one in mm/kasan/kasan.h). I'd remove the latter and try to have a consistent approach for kasan_report() and kasan_report_async(). -- Catalin