linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Grant Likely <grant.likely@arm.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Madalin Bucur <madalin.bucur@oss.nxp.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
	Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>,
	Randy Dunlap <rdunlap@infradead.org>
Cc: linux.cj@gmail.com,
	Diana Madalina Craciun <diana.craciun@nxp.com>,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Calvin Johnson <calvin.johnson@oss.nxp.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: [net-next PATCH v4 09/15] device property: Introduce fwnode_get_id()
Date: Fri, 22 Jan 2021 21:12:54 +0530	[thread overview]
Message-ID: <20210122154300.7628-10-calvin.johnson@oss.nxp.com> (raw)
In-Reply-To: <20210122154300.7628-1-calvin.johnson@oss.nxp.com>

Using fwnode_get_id(), get the reg property value for DT node
or get the _ADR object value for ACPI node.

Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
---

Changes in v4:
- Improve code structure to handle all cases

Changes in v3:
- Modified to retrieve reg property value for ACPI as well
- Resolved compilation issue with CONFIG_ACPI = n
- Added more info into documentation

Changes in v2: None

 drivers/base/property.c  | 34 ++++++++++++++++++++++++++++++++++
 include/linux/property.h |  1 +
 2 files changed, 35 insertions(+)

diff --git a/drivers/base/property.c b/drivers/base/property.c
index 35b95c6ac0c6..f0581bbf7a4b 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -580,6 +580,40 @@ const char *fwnode_get_name_prefix(const struct fwnode_handle *fwnode)
 	return fwnode_call_ptr_op(fwnode, get_name_prefix);
 }
 
+/**
+ * fwnode_get_id - Get the id of a fwnode.
+ * @fwnode: firmware node
+ * @id: id of the fwnode
+ *
+ * This function provides the id of a fwnode which can be either
+ * DT or ACPI node. For ACPI, "reg" property value, if present will
+ * be provided or else _ADR value will be provided.
+ * Returns 0 on success or a negative errno.
+ */
+int fwnode_get_id(struct fwnode_handle *fwnode, u32 *id)
+{
+#ifdef CONFIG_ACPI
+	unsigned long long adr;
+	acpi_status status;
+#endif
+	int ret;
+
+	ret = fwnode_property_read_u32(fwnode, "reg", id);
+	if (ret) {
+#ifdef CONFIG_ACPI
+		status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(fwnode),
+					       METHOD_NAME__ADR, NULL, &adr);
+		if (ACPI_FAILURE(status))
+			return -EINVAL;
+		*id = (u32)adr;
+#else
+		return ret;
+#endif
+	}
+	return 0;
+}
+EXPORT_SYMBOL_GPL(fwnode_get_id);
+
 /**
  * fwnode_get_parent - Return parent firwmare node
  * @fwnode: Firmware whose parent is retrieved
diff --git a/include/linux/property.h b/include/linux/property.h
index 0a9001fe7aea..3f41475f010b 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -82,6 +82,7 @@ struct fwnode_handle *fwnode_find_reference(const struct fwnode_handle *fwnode,
 
 const char *fwnode_get_name(const struct fwnode_handle *fwnode);
 const char *fwnode_get_name_prefix(const struct fwnode_handle *fwnode);
+int fwnode_get_id(struct fwnode_handle *fwnode, u32 *id);
 struct fwnode_handle *fwnode_get_parent(const struct fwnode_handle *fwnode);
 struct fwnode_handle *fwnode_get_next_parent(
 	struct fwnode_handle *fwnode);
-- 
2.17.1


  parent reply	other threads:[~2021-01-22 15:50 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 15:42 [net-next PATCH v4 00/15] ACPI support for dpaa2 driver Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 01/15] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2021-01-22 19:22   ` Rafael J. Wysocki
2021-01-28 11:27     ` Calvin Johnson
2021-01-28 12:00       ` Rafael J. Wysocki
2021-01-28 13:12         ` Calvin Johnson
2021-01-28 13:27           ` Rafael J. Wysocki
2021-01-29  6:47             ` Calvin Johnson
2021-01-29 16:37               ` Rafael J. Wysocki
2021-01-29 16:44                 ` Rafael J. Wysocki
2021-01-29 17:21                   ` Andy Shevchenko
2021-01-22 15:42 ` [net-next PATCH v4 02/15] net: phy: Introduce fwnode_mdio_find_device() Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 03/15] net: phy: Introduce phy related fwnode functions Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 04/15] of: mdio: Refactor of_phy_find_device() Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 05/15] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 06/15] of: mdio: Refactor of_get_phy_id() Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2021-02-05 17:25   ` Calvin Johnson
2021-02-05 18:25     ` Andy Shevchenko
2021-02-05 18:41       ` Andy Shevchenko
2021-02-05 18:58         ` Andy Shevchenko
2021-02-06 17:14           ` Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 08/15] of: mdio: Refactor of_mdiobus_register_phy() Calvin Johnson
2021-01-22 15:42 ` Calvin Johnson [this message]
2021-01-22 16:24   ` [net-next PATCH v4 09/15] device property: Introduce fwnode_get_id() Andy Shevchenko
2021-01-22 16:40   ` Rafael J. Wysocki
2021-01-22 17:13     ` Andy Shevchenko
2021-01-22 18:11       ` Rafael J. Wysocki
2021-01-22 18:21         ` Rafael J. Wysocki
2021-01-22 18:13   ` Rafael J. Wysocki
2021-01-22 18:35     ` Rafael J. Wysocki
2021-01-22 15:42 ` [net-next PATCH v4 10/15] net: mdio: Add ACPI support code for mdio Calvin Johnson
2021-01-23  1:39   ` Jakub Kicinski
2021-01-22 15:42 ` [net-next PATCH v4 11/15] net: mdiobus: Introduce fwnode_mdiobus_register() Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 12/15] net/fsl: Use fwnode_mdiobus_register() Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 13/15] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2021-01-22 15:42 ` [net-next PATCH v4 14/15] net: phylink: Refactor phylink_of_phy_connect() Calvin Johnson
2021-01-22 15:43 ` [net-next PATCH v4 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122154300.7628-10-calvin.johnson@oss.nxp.com \
    --to=calvin.johnson@oss.nxp.com \
    --cc=andrew@lunn.ch \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=cristian.sovaiala@nxp.com \
    --cc=diana.craciun@nxp.com \
    --cc=f.fainelli@gmail.com \
    --cc=florinlaurentiu.chiculita@nxp.com \
    --cc=grant.likely@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=jeremy.linton@arm.com \
    --cc=jon@solid-run.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurentiu.tudor@nxp.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.cj@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=madalin.bucur@oss.nxp.com \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    --cc=pieter.jansenvv@bamboosystems.io \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).