From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, lgirdwood@gmail.com,
broonie@kernel.org, sumit.semwal@linaro.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
phone-devel@vger.kernel.org, konrad.dybcio@somainline.org,
marijn.suijten@somainline.org, martin.botka@somainline.org
Subject: Re: [PATCH v4 4/7] dt-bindings: regulator: qcom-labibb: Document soft start properties
Date: Fri, 22 Jan 2021 11:01:37 -0600 [thread overview]
Message-ID: <20210122170137.GA962214@robh.at.kernel.org> (raw)
In-Reply-To: <20210119174421.226541-5-angelogioacchino.delregno@somainline.org>
On Tue, Jan 19, 2021 at 06:44:18PM +0100, AngeloGioacchino Del Regno wrote:
> Document properties to configure soft start and discharge resistor
> for LAB and IBB respectively.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> .../bindings/regulator/qcom-labibb-regulator.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> index 53853ec20fe2..7a507692f1ba 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> @@ -22,6 +22,11 @@ properties:
> type: object
>
> properties:
> + qcom,soft-start-us:
> + $ref: /schemas/types.yaml#/definitions/uint32
Don't need a type when you have standard units.
> + description: Regulator soft start time in microseconds.
> + enum: [200, 400, 600, 800]
> + default: 200
>
> interrupts:
> maxItems: 1
> @@ -35,6 +40,11 @@ properties:
> type: object
>
> properties:
> + qcom,discharge-resistor-kohms:
-kohms is not standard units as documented in property-units.txt (and
.yaml in dtschema). Please use '-ohms'.
Given this is already applied, send an incremental patch.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Discharge resistor value in KiloOhms.
> + enum: [300, 64, 32, 16]
> + default: 300
>
> interrupts:
> maxItems: 1
> --
> 2.30.0
>
next prev parent reply other threads:[~2021-01-22 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 17:44 [PATCH v4 0/7] Really implement Qualcomm LAB/IBB regulators AngeloGioacchino Del Regno
2021-01-19 17:44 ` [PATCH v4 1/7] regulator: qcom-labibb: Switch voltage ops from linear_range to linear AngeloGioacchino Del Regno
2021-01-19 17:44 ` [PATCH v4 2/7] regulator: qcom-labibb: Implement current limiting AngeloGioacchino Del Regno
2021-01-19 17:44 ` [PATCH v4 3/7] regulator: qcom-labibb: Implement pull-down, softstart, active discharge AngeloGioacchino Del Regno
2021-01-19 17:44 ` [PATCH v4 4/7] dt-bindings: regulator: qcom-labibb: Document soft start properties AngeloGioacchino Del Regno
2021-01-22 17:01 ` Rob Herring [this message]
2021-01-19 17:44 ` [PATCH v4 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs AngeloGioacchino Del Regno
2021-01-19 17:44 ` [PATCH v4 6/7] dt-bindings: regulator: qcom-labibb: Document SCP/OCP interrupts AngeloGioacchino Del Regno
2021-01-22 17:09 ` Rob Herring
2021-01-19 17:44 ` [PATCH v4 7/7] arm64: dts: pmi8998: Add the right interrupts for LAB/IBB SCP and OCP AngeloGioacchino Del Regno
2021-01-21 0:07 ` (subset) [PATCH v4 0/7] Really implement Qualcomm LAB/IBB regulators Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122170137.GA962214@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).