From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79EDCC433DB for ; Sat, 23 Jan 2021 03:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4517523B2F for ; Sat, 23 Jan 2021 03:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726656AbhAWD7Z (ORCPT ); Fri, 22 Jan 2021 22:59:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58742 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbhAWD7W (ORCPT ); Fri, 22 Jan 2021 22:59:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611374275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJ9Mm5Q1SkM9lfn4njziV+U6R5yBys70RfxEBh9Yi+c=; b=dbe2JFS1dogNfbJ/cJo4tHGNrYmmmf85fSynO9MQ5owX+tIpq90M/KFp9vwhfvrfgfukcb 3TbsAO9Ck8zjrUYijH0BX8DrxWl9p3RNHWy8npcsCjpv7JjLpdsD4XrF24rGUpeZvZkfYi aFdARL2j8o02ylIHThc/u7f2LAC0lp4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-602-3tQGP1XmNuKJg-RaQaU7Cw-1; Fri, 22 Jan 2021 22:57:51 -0500 X-MC-Unique: 3tQGP1XmNuKJg-RaQaU7Cw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0958F8018A3; Sat, 23 Jan 2021 03:57:48 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-54.pek2.redhat.com [10.72.12.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D90CA5DA2D; Sat, 23 Jan 2021 03:57:36 +0000 (UTC) Date: Sat, 23 Jan 2021 11:57:33 +0800 From: Dave Young To: Saeed Mirzamohammadi Cc: John Donnelly , Guilherme Piccoli , Kairui Song , Geert Uytterhoeven , linux-doc@vger.kernel.org, Catalin Marinas , Bjorn Andersson , "H. Peter Anvin" , Will Deacon , Anson Huang , Jonathan Corbet , the arch/x86 maintainers , Michael Walle , Krzysztof Kozlowski , Ingo Molnar , Vivek Goyal , Arnd Bergmann , Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Baoquan He , "Martin K. Petersen" , Randy Dunlap , kexec mailing list , Linux Kernel Mailing List , "# v4 . 16+" , Li Yang , Miguel Ojeda , Vinod Koul , Diego Elio =?iso-8859-1?Q?Petten=F2?= , Olof Johansson , Shawn Guo Subject: Re: [PATCH 1/1] kernel/crash_core.c - Add crashkernel=auto for x86 and ARM Message-ID: <20210123035733.GA6865@dhcp-128-65.nay.redhat.com> References: <20201123034705.GA5908@dhcp-128-65.nay.redhat.com> <20210122012254.GA3174@dhcp-128-65.nay.redhat.com> <20210122031244.GA4717@dhcp-128-65.nay.redhat.com> <730EBE33-5571-49C0-AF38-08C49736EB70@oracle.com> <20210123035126.GA6539@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210123035126.GA6539@dhcp-128-65.nay.redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/21 at 11:51am, Dave Young wrote: > Hi Saeed, > On 01/22/21 at 05:14pm, Saeed Mirzamohammadi wrote: > > Hi, > > > > > On Jan 21, 2021, at 7:12 PM, Dave Young wrote: > > > > > > On 01/22/21 at 09:22am, Dave Young wrote: > > >> Hi John, > > >> > > >> On 01/21/21 at 09:32am, john.p.donnelly@oracle.com wrote: > > >>> On 11/22/20 9:47 PM, Dave Young wrote: > > >>>> Hi Guilherme, > > >>>> On 11/22/20 at 12:32pm, Guilherme Piccoli wrote: > > >>>>> Hi Dave and Kairui, thanks for your responses! OK, if that makes sense > > >>>>> to you I'm fine with it. I'd just recommend to test recent kernels in > > >>>>> multiple distros with the minimum "range" to see if 64M is enough for > > >>>>> crashkernel, maybe we'd need to bump that. > > >>>> > > >>>> Giving the different kernel configs and the different userspace > > >>>> initramfs setup it is hard to get an uniform value for all distributions, > > >>>> but we can have an interface/kconfig-option for them to provide a value like this patch > > >>>> is doing. And it could be improved like Kairui said about some known > > >>>> kernel added extra values later, probably some more improvements if > > >>>> doable. > > >>>> > > >>>> Thanks > > >>>> Dave > > >>>> > > >>> > > >>> Hi. > > >>> > > >>> Are we going to move forward with implementing this for X86 and Arm ? > > >>> > > >>> If other platform maintainers want to include this CONFIG option in their > > >>> configuration settings they have a starting point. > > >> > > >> I would expect this become arch independent. > > > > > > Clarify a bit, it can be a general config option under arch/Kconfig and > > > just put the code in general arch independent part. > > > > Does this mean that we need to add the option to def_configs in all archs as well? > > > > I think we do not need to add defconfig, something like this will just work? > > BTW, it should depend on CRASH_CORE instead of CRASH_DUMP, the logic of > parsing crashkernel is in kernel/crash_core.c > > diff --git a/arch/Kconfig b/arch/Kconfig > index af14a567b493..fa6efeb52dc5 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -14,6 +14,11 @@ menu "General architecture-dependent options" > config CRASH_CORE > bool > > +config CRASH_AUTO_STR > + depends on CRASH_CORE > + string "Memory reserved for crash kernel" > + default "1G-:128M" People do not want to see the default value if they do not need kdump so it would be better to add another kconfig option as a switch which is set default as off in bool state. > + ... help text [snip] ... > + > config KEXEC_CORE > select CRASH_CORE > bool > > [...] > > > Thanks, > > Saeed > > > > > > > >> > > >> Saeed, Kairui, would any of you like to update the patch? > > >> > > >>> > > >>> Thank you, > > >>> > > >>> John. > > >>> > > >>> ( I am not currently on many of the included dist lists in this email, so > > >>> hopefully key contributors are included in this exchange ) > > >>> > > >> > > >> Thanks > > >> Dave > > > > Thanks > Dave