* [PATCH] PM: remove PF_WQ_WORKER mask
@ 2021-01-25 4:18 qiang.zhang
2021-01-27 3:18 ` 回复: " Zhang, Qiang
2021-01-27 18:16 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: qiang.zhang @ 2021-01-25 4:18 UTC (permalink / raw)
To: rafael.j.wysocki; +Cc: linux-pm, linux-kernel
From: Zqiang <qiang.zhang@windriver.com>
Due to kworker also is kernel thread, it's already included
PF_KTHREAD mask, so remove PF_WQ_WORKER mask.
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
---
kernel/power/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power/process.c b/kernel/power/process.c
index 45b054b7b5ec..50cc63534486 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -235,7 +235,7 @@ void thaw_kernel_threads(void)
read_lock(&tasklist_lock);
for_each_process_thread(g, p) {
- if (p->flags & (PF_KTHREAD | PF_WQ_WORKER))
+ if (p->flags & PF_KTHREAD)
__thaw_task(p);
}
read_unlock(&tasklist_lock);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* 回复: [PATCH] PM: remove PF_WQ_WORKER mask
2021-01-25 4:18 [PATCH] PM: remove PF_WQ_WORKER mask qiang.zhang
@ 2021-01-27 3:18 ` Zhang, Qiang
2021-01-27 18:16 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Qiang @ 2021-01-27 3:18 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-pm, linux-kernel
________________________________________
发件人: Zhang, Qiang <qiang.zhang@windriver.com>
发送时间: 2021年1月25日 12:00
收件人: rafael.j.wysocki@intel.com
抄送: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org
主题: [PATCH] PM: remove PF_WQ_WORKER mask
From: Zqiang <qiang.zhang@windriver.com>
Due to kworker also is kernel thread, it's already included
PF_KTHREAD mask, so remove PF_WQ_WORKER mask.
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
---
kernel/power/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power/process.c b/kernel/power/process.c
index 45b054b7b5ec..50cc63534486 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -235,7 +235,7 @@ void thaw_kernel_threads(void)
read_lock(&tasklist_lock);
for_each_process_thread(g, p) {
- if (p->flags & (PF_KTHREAD | PF_WQ_WORKER))
+ if (p->flags & PF_KTHREAD)
__thaw_task(p);
}
read_unlock(&tasklist_lock);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PM: remove PF_WQ_WORKER mask
2021-01-25 4:18 [PATCH] PM: remove PF_WQ_WORKER mask qiang.zhang
2021-01-27 3:18 ` 回复: " Zhang, Qiang
@ 2021-01-27 18:16 ` Rafael J. Wysocki
2021-01-28 1:42 ` 回复: " Zhang, Qiang
1 sibling, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-01-27 18:16 UTC (permalink / raw)
To: qiang.zhang; +Cc: Rafael Wysocki, Linux PM, Linux Kernel Mailing List
On Mon, Jan 25, 2021 at 5:01 AM <qiang.zhang@windriver.com> wrote:
>
> From: Zqiang <qiang.zhang@windriver.com>
>
> Due to kworker also is kernel thread, it's already included
> PF_KTHREAD mask, so remove PF_WQ_WORKER mask.
So you are saying that all threads having PF_WQ_WORKER set must also
have PF_KTHREAD set, right?
That sounds correct, so I'm going to rewrite the changelog and apply
the patch as 5.12 material, thanks!
> Signed-off-by: Zqiang <qiang.zhang@windriver.com>
> ---
> kernel/power/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index 45b054b7b5ec..50cc63534486 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -235,7 +235,7 @@ void thaw_kernel_threads(void)
>
> read_lock(&tasklist_lock);
> for_each_process_thread(g, p) {
> - if (p->flags & (PF_KTHREAD | PF_WQ_WORKER))
> + if (p->flags & PF_KTHREAD)
> __thaw_task(p);
> }
> read_unlock(&tasklist_lock);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [PATCH] PM: remove PF_WQ_WORKER mask
2021-01-27 18:16 ` Rafael J. Wysocki
@ 2021-01-28 1:42 ` Zhang, Qiang
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qiang @ 2021-01-28 1:42 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Rafael Wysocki, Linux PM, Linux Kernel Mailing List
________________________________________
发件人: Rafael J. Wysocki <rafael@kernel.org>
发送时间: 2021年1月28日 2:16
收件人: Zhang, Qiang
抄送: Rafael Wysocki; Linux PM; Linux Kernel Mailing List
主题: Re: [PATCH] PM: remove PF_WQ_WORKER mask
[Please note: This e-mail is from an EXTERNAL e-mail address]
On Mon, Jan 25, 2021 at 5:01 AM <qiang.zhang@windriver.com> wrote:
>
> From: Zqiang <qiang.zhang@windriver.com>
>
> Due to kworker also is kernel thread, it's already included
> PF_KTHREAD mask, so remove PF_WQ_WORKER mask.
>So you are saying that all threads having PF_WQ_WORKER set must also
>have PF_KTHREAD set, right?
yes
#define PF_KTHREAD 0x00200000
#define PF_WQ_WORKER 0x00000020
I tracing kwoker's task->flags as follows:
comm kworker/1:0, cpu 1, task->flags 0x4208060, delayed 3, func intel_fbc_work_fn
Thanks
Qiang
>That sounds correct, so I'm going to rewrite the changelog and apply
>the patch as 5.12 material, thanks!
> Signed-off-by: Zqiang <qiang.zhang@windriver.com>
> ---
> kernel/power/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index 45b054b7b5ec..50cc63534486 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -235,7 +235,7 @@ void thaw_kernel_threads(void)
>
> read_lock(&tasklist_lock);
> for_each_process_thread(g, p) {
> - if (p->flags & (PF_KTHREAD | PF_WQ_WORKER))
> + if (p->flags & PF_KTHREAD)
> __thaw_task(p);
> }
> read_unlock(&tasklist_lock);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-28 1:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 4:18 [PATCH] PM: remove PF_WQ_WORKER mask qiang.zhang
2021-01-27 3:18 ` 回复: " Zhang, Qiang
2021-01-27 18:16 ` Rafael J. Wysocki
2021-01-28 1:42 ` 回复: " Zhang, Qiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).