From: Jan Kara <jack@suse.cz>
To: Chunguang Xu <brookxu.cn@gmail.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] make jbd2 debug switch per device
Date: Mon, 25 Jan 2021 13:41:17 +0100 [thread overview]
Message-ID: <20210125124117.GB1175@quack2.suse.cz> (raw)
In-Reply-To: <cover.1611287342.git.brookxu@tencent.com>
On Fri 22-01-21 14:43:18, Chunguang Xu wrote:
> On a multi-disk machine, because jbd2 debugging switch is global, this
> confuses the logs of multiple disks. It is not easy to distinguish the
> logs of each disk and the amount of generated logs is very large. Or a
> separate debugging switch for each disk would be better, so that you
> can easily distinguish the logs of a certain disk.
>
> We can enable jbd2 debugging of a device in the following ways:
> echo X > /proc/fs/jbd2/sdX/jbd2_debug
>
> But there is a small disadvantage here. Because the debugging switch is
> placed in the journal_t object, the log before the object is initialized
> will be lost. However, usually this will not have much impact on
> debugging.
OK, I didn't look at the series yet but I'm wondering: How are you using
jbd2 debugging? I mean obviously it isn't meant for production use but
rather for debugging JBD2 bugs so I'm kind of wondering in which case too
many messages matter.
And if the problem is that there's a problem with distinguishing messages
from multiple filesystems, then it would be perhaps more useful to add
journal identification to each message similarly as we do it with ext4
messages (likely by using journal->j_dev) - which is very simple to do
after your patches 3 and 4.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-01-26 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 6:43 [RFC PATCH 0/4] make jbd2 debug switch per device Chunguang Xu
2021-01-22 6:43 ` [RFC PATCH 1/4] jbd2: make jdb2_debug module parameter " Chunguang Xu
2021-01-22 19:00 ` harshad shirwadkar
2021-01-23 3:15 ` brookxu
2021-01-22 6:43 ` [RFC PATCH 2/4] jbd2: introduce some new log interfaces Chunguang Xu
2021-01-22 6:43 ` [RFC PATCH 3/4] jbd2: replace jbd_debug with the new log interface Chunguang Xu
2021-01-22 6:43 ` [RFC PATCH 4/4] ext4: " Chunguang Xu
2021-01-25 12:41 ` Jan Kara [this message]
2021-01-25 13:59 ` [RFC PATCH 0/4] make jbd2 debug switch per device brookxu
2021-01-25 14:07 ` 许春光
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125124117.GB1175@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=brookxu.cn@gmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).