From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58757C433E9 for ; Tue, 26 Jan 2021 06:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A95722B51 for ; Tue, 26 Jan 2021 06:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730464AbhAZG3T (ORCPT ); Tue, 26 Jan 2021 01:29:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729161AbhAYN56 (ORCPT ); Mon, 25 Jan 2021 08:57:58 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F697C061786 for ; Mon, 25 Jan 2021 05:57:03 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id 6so12632757wri.3 for ; Mon, 25 Jan 2021 05:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=gp+PA16ZKrofmtCmx5UhAkgHt0xYogsEGnsOJd6xTQE=; b=NjF0v5DM0oqi8sw3YmeQQIJUkZfUfqK64M3Yi82RuNzJls6JgVdgIjkxiXnZzo1qq0 J73iuRwsB90hlBOt6ILA7lZO3U5d7AapAQma5JRNgDM8EMSIjVP9rWbNn1tb3nUOEdxn dOPMPvOvwB21iTmclhTVfRRuZ3KYA/35xII87arNPAgi6hbrLv497OF/u8J3D00h7l6O XqsRq5GS9r2gc55GcpiZmh6y0YlK61v4fUlHIMek2mus/+iIZKMSFZJmbeE55HFXASgn WSzP8e7ahIXJpxohMkbLFi5NXVd/CucpXHP0tpaDaRuTOTEAO9BALNx7wmkQTqy567+n Jp0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gp+PA16ZKrofmtCmx5UhAkgHt0xYogsEGnsOJd6xTQE=; b=LebIZRX/vaRzws9/q0Iw1p6CD/pZuE5WZ/OvM1qosTUO++BeWykPhxdm1eczjhaxhL E4GXJDNe1LmGUVRm1/zOb5vZu9zezHUuvDMmO38j70XWRjKfWxX1Mwlnzb3m7LZb9Pig ArVfQFRNkYUJC55Qsf2xG4zkGC5frI0VSbf3rVzH2oHNT8MxtZidDOZh93E0Z/2klUzF iyavNANnFL2iZEfTsP4CF1d+m4BcdelPSFpWF7e6XVtgd74iS187YjKNXMgELfITibKZ Cm8x3W9Dckf+frUPqmb4nwnG4TS/MgUwe3hsaXdpOvxS32azX/m5n9v7r9L1WwKru2v0 R2mg== X-Gm-Message-State: AOAM5321KN58qHVipaQM6VrvaOUR3FQW1Yy2lLJs5JG7u2JSpetDTWpn PPhxTUIEg4AbiZFnUgt34aqa5g== X-Google-Smtp-Source: ABdhPJyi2GzmE6f+sfhyMtpP1PlJIpmf78IeJrAWHg2Oa08dZ6qBFoHoZBQqh2g2gbVG82raB5QfKA== X-Received: by 2002:adf:eed0:: with SMTP id a16mr1085622wrp.107.1611583021391; Mon, 25 Jan 2021 05:57:01 -0800 (PST) Received: from dell ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id g1sm22627542wrq.30.2021.01.25.05.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 05:57:00 -0800 (PST) Date: Mon, 25 Jan 2021 13:56:58 +0000 From: Lee Jones To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Rob Herring , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alessandro Zummo , Alexandre Belloni , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 04/17] mfd: bd718x7: simplify by cleaning unnecessary device data Message-ID: <20210125135658.GX4903@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jan 2021, Matti Vaittinen wrote: > Most ROHM PMIC sub-devices only use the regmap pointer from > parent device. They can obtain this by dev_get_regamap so in > most cases the MFD device does not need to allocate and populate > the driver data. Simplify drivers by removing this. > > The BD70528 still needs the access to watchdog mutex so keep > rohm_regmap_dev in use on BD70528 RTC and WDG drivers for now. > > Signed-off-by: Matti Vaittinen > --- > > No changes since v1 > > drivers/mfd/rohm-bd718x7.c | 43 ++++++++++++-------------------- > include/linux/mfd/rohm-bd718x7.h | 13 ---------- > 2 files changed, 16 insertions(+), 40 deletions(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog