From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: iio: Add cros ec proximity yaml doc
Date: Mon, 25 Jan 2021 09:02:03 -0600 [thread overview]
Message-ID: <20210125150203.GA341275@robh.at.kernel.org> (raw)
In-Reply-To: <20210124172756.69ef7c5a@archlinux>
On Sun, Jan 24, 2021 at 05:27:56PM +0000, Jonathan Cameron wrote:
> On Fri, 22 Jan 2021 14:54:42 -0800
> Stephen Boyd <swboyd@chromium.org> wrote:
>
> > Some cros ECs support a front proximity MKBP event via
> > 'EC_MKBP_FRONT_PROXIMITY'. Add a DT binding to document this feature via
> > a node that is a child of the main cros_ec device node. Devices that
> > have this ability will describe this in firmware.
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Benson Leung <bleung@chromium.org>
> > Cc: Guenter Roeck <groeck@chromium.org>
> > Cc: Douglas Anderson <dianders@chromium.org>
> > Cc: Gwendal Grignou <gwendal@chromium.org>
> > Cc: <devicetree@vger.kernel.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > ---
> > .../proximity/google,cros-ec-proximity.yaml | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml b/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml
> > new file mode 100644
> > index 000000000000..c0a34bdfe4fd
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml
> > @@ -0,0 +1,37 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
> > +$id: http://devicetree.org/schemas/iio/proximity/google,cros-ec-proximity.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ChromeOS EC MKBP Proximity Sensor
> > +
> > +maintainers:
> > + - Stephen Boyd <swboyd@chromium.org>
> > + - Benson Leung <bleung@chromium.org>
> > + - Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > +
> > +description: |
> > + Google's ChromeOS EC sometimes has the ability to detect user proximity.
> > + This is implemented on the EC as near/far logic and exposed to the OS
> > + via an MKBP switch bit.
> > +
> > +properties:
> > + compatible:
> > + const: google,cros-ec-proximity
> > +
> > + label:
> > + description: Name for proximity sensor
> > +
> > +required:
> > + - compatible
> > +
> > +unevaluatedProperties: false
additionalProperties: false
> > +
> > +examples:
> > + - |
> > + proximity {
>
> Can we at least have the example making it clear this is a child of the
> cros_ec device?
Move this to the core Cros EC binding. The core binding needs to define
'proximity' and reference this binding ($ref).
>
> > + compatible = "google,cros-ec-proximity";
> > + label = "proximity-wifi-lte";
> > + };
>
next prev parent reply other threads:[~2021-01-26 6:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 22:54 [PATCH 0/3] iio: Add a ChromeOS EC MKBP proximity driver Stephen Boyd
2021-01-22 22:54 ` [PATCH 1/3] platform/chrome: cros_ec: Add SW_FRONT_PROXIMITY MKBP define Stephen Boyd
2021-01-22 22:54 ` [PATCH 2/3] dt-bindings: iio: Add cros ec proximity yaml doc Stephen Boyd
2021-01-24 17:27 ` Jonathan Cameron
2021-01-24 20:42 ` Gwendal Grignou
2021-01-25 18:33 ` Stephen Boyd
2021-01-25 15:02 ` Rob Herring [this message]
2021-01-25 18:53 ` Stephen Boyd
2021-01-24 22:33 ` Rob Herring
2021-01-22 22:54 ` [PATCH 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver Stephen Boyd
2021-01-24 17:38 ` Jonathan Cameron
2021-01-24 21:41 ` Gwendal Grignou
2021-01-25 18:52 ` Stephen Boyd
2021-01-25 22:28 ` Gwendal Grignou
2021-01-25 23:44 ` Stephen Boyd
2021-01-26 20:59 ` Gwendal Grignou
2021-01-28 8:32 ` Stephen Boyd
2021-01-25 18:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125150203.GA341275@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).