From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB510C433E0 for ; Mon, 25 Jan 2021 23:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A88A227BF for ; Mon, 25 Jan 2021 23:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732174AbhAYXYh (ORCPT ); Mon, 25 Jan 2021 18:24:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:35726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732710AbhAYXX2 (ORCPT ); Mon, 25 Jan 2021 18:23:28 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8F7E021D93; Mon, 25 Jan 2021 23:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1611616958; bh=XH7o6BXLIqIYaGWEZfAOHh39LYn7HZemY8tFhMvJ2dM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JMhXNc1DfCG1TUjT9FxgF1jgnk+hDAELuuTUKJP6LFumwcEcxLrbpvhIvhofBwVKN 3DP+iRwua1qj8UOpxOelV2f27uyZrH2QakZMs0945/KwIecL/l7uZd1qhMfu1PGP1T D4wjUVBz16FvIrEpzQ3qtphiq4/KrUSil0g2Lwsk= Date: Mon, 25 Jan 2021 15:22:37 -0800 From: Andrew Morton To: Baolin Wang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/filemap: Remove redundant variable's assignment Message-Id: <20210125152237.d3cfebac78907fb50ae5cbbc@linux-foundation.org> In-Reply-To: <08dc7237b44b9455ab095b44dc6969a1607b08db.1611544316.git.baolin.wang@linux.alibaba.com> References: <08dc7237b44b9455ab095b44dc6969a1607b08db.1611544316.git.baolin.wang@linux.alibaba.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jan 2021 11:20:02 +0800 Baolin Wang wrote: > We've already set the variable 'i' 's initial value before using it, > thus remove redundant previous assignment of variable 'i'. > > ... > > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2472,7 +2472,6 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb, > if ((iocb->ki_flags & IOCB_WAITQ) && written) > iocb->ki_flags |= IOCB_NOWAIT; > > - i = 0; > pg_nr = generic_file_buffered_read_get_pages(iocb, iter, > pages, nr_pages); > if (pg_nr < 0) { Matthew's patch series "Refactor generic_file_buffered_read " (https://lkml.kernel.org/r/20210122160140.223228-1-willy@infradead.org) changes all this code - I dont think the patch is relevant after that, so I'll skip it.