From: Rob Herring <robh@kernel.org>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Cc: ulf.hansson@linaro.org, broonie@kernel.org, lgirdwood@gmail.com,
devicetree@vger.kernel.org, adrian.hunter@intel.com,
michal.simek@xilinx.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com,
Rashmi.A@intel.com, mahesh.r.vaidya@intel.com
Subject: Re: [PATCH v1 9/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC
Date: Mon, 25 Jan 2021 15:37:58 -0600 [thread overview]
Message-ID: <20210125213758.GA1026926@robh.at.kernel.org> (raw)
In-Reply-To: <20210114152700.21916-10-muhammad.husaini.zulkifli@intel.com>
On Thu, Jan 14, 2021 at 11:27:00PM +0800, Muhammad Husaini Zulkifli wrote:
> Keem Bay SOC can support dual voltage operations for GPIO SD pins to
> either 1.8V or 3.3V for bus IO line power. In order to operate the GPIOs
> line for Clk, Cmd and Data on Keem Bay hardware, it is important to
> configure the supplied voltage applied to their I/O Rail and the output
> of the I²C expander pin. Final Voltage applied on the GPIOs line are
> dependent by both supplied voltage rail and expander pin output as it is
> been set after passing through the voltage sense resistor.
>
> Keem Bay hardware is somewhat unique in the way of how IO bus line
> voltage are been controlled.
>
> Expander pin output is controlled by gpio-regulator. Voltage rail output
> is controlled by Keem Bay SD regulator. Keem Bay SD regulator encapsulated
> the Secure Monitor Calling Convention (SMCCC) to communicate with Trusted
> Firmware during set voltage operation.
>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 263 +++++++++++++++++++++++++++++
> 1 file changed, 263 insertions(+)
> + u32 otap_delay, sel_clk_buffer;
> +
> + phys = of_parse_phandle(dev->of_node, "phys", 0);
Normally, you'd use the phy API here. Though not required from a DT
perspective.
> + if (!phys) {
> + dev_err(dev, "Can't get phys for sd0\n");
> + return -ENODEV;
> + }
> +
> + of_property_read_u32(phys, "intel,keembay-emmc-phy-otap-dly", &otap_delay);
> + of_property_read_u32(phys, "intel,keembay-emmc-phy-sel-clkbuf", &sel_clk_buffer);
Not doucmented?
For property names, I'd leave out the SoC name. Might want to use it in
the next chip.
Rob
next prev parent reply other threads:[~2021-01-25 21:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 15:26 [PATCH v1 0/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 1/9] mmc: sdhci-of-arasan: use of_device_get_match_data() Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 2/9] mmc: sdhci-of-arasan: Convert to use np instead of pdev->dev.of_node Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 3/9] mmc: sdhci-of-arasan: Add structure device pointer in probe function Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 4/9] mmc: sdhci-of-arasan: Use dev_err_probe() to avoid spamming logs Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 5/9] firmware: keembay: Add support for Trusted Firmware Service call Muhammad Husaini Zulkifli
2021-01-14 16:48 ` Mark Brown
2021-01-15 18:58 ` Sudeep Holla
2021-01-18 10:28 ` Zulkifli, Muhammad Husaini
2021-01-18 11:19 ` Mark Brown
2021-01-18 11:55 ` Sudeep Holla
2021-01-18 12:01 ` Cristian Marussi
2021-01-19 2:38 ` Zulkifli, Muhammad Husaini
2021-01-19 17:20 ` Sudeep Holla
2021-01-14 15:26 ` [PATCH v1 6/9] dt-bindings: mmc: Update phy and regulator supply for Keem Bay SOC Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 7/9] dt-bindings: regulator: keembay: Add DT binding documentation Muhammad Husaini Zulkifli
2021-01-14 16:52 ` Mark Brown
2021-01-14 15:26 ` [PATCH v1 8/9] regulator: keembay: Add regulator for Keem Bay SoC Muhammad Husaini Zulkifli
2021-01-14 17:14 ` Mark Brown
2021-01-15 19:14 ` Sudeep Holla
2021-01-14 15:27 ` [PATCH v1 9/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC Muhammad Husaini Zulkifli
2021-01-25 21:37 ` Rob Herring [this message]
2021-01-19 13:42 ` [PATCH v1 0/9] " Ulf Hansson
2021-01-20 4:24 ` Zulkifli, Muhammad Husaini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125213758.GA1026926@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Rashmi.A@intel.com \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mahesh.r.vaidya@intel.com \
--cc=michal.simek@xilinx.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).