From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
Dave Airlie <airlied@gmail.com>,
greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org (open list)
Subject: [RFC v2 2/5] drm/nouveau/kms: Don't probe eDP connectors more then once
Date: Mon, 25 Jan 2021 19:10:28 -0500 [thread overview]
Message-ID: <20210126001031.881048-3-lyude@redhat.com> (raw)
In-Reply-To: <20210126001031.881048-1-lyude@redhat.com>
eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a
connection status change is being forced, of course).
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 14c29e68db8f..f4d16576a7da 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -556,6 +556,12 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
int ret;
enum drm_connector_status conn_status = connector_status_disconnected;
+ /* eDP doesn't do hotplugging, never probe more then once */
+ if (nv_connector->type == DCB_CONNECTOR_eDP &&
+ connector->force == DRM_FORCE_UNSPECIFIED &&
+ connector->status != connector_status_unknown)
+ return connector->status;
+
/* Outputs are only polled while runtime active, so resuming the
* device here is unnecessary (and would deadlock upon runtime suspend
* because it waits for polling to finish). We do however, want to
--
2.29.2
next prev parent reply other threads:[~2021-01-26 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210126001031.881048-1-lyude@redhat.com>
2021-01-26 0:10 ` [RFC v2 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once Lyude Paul
2021-01-26 0:10 ` Lyude Paul [this message]
2021-01-26 0:10 ` [RFC v2 3/5] drm/i915/dp: Remove redundant AUX backlight frequency calculations Lyude Paul
2021-01-26 0:10 ` [RFC v2 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers Lyude Paul
2021-02-03 20:58 ` Rodrigo Vivi
2021-02-03 21:29 ` Lyude Paul
2021-01-26 0:10 ` [RFC v2 5/5] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126001031.881048-3-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=greg.depoire@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).