From: Christoph Hellwig <hch@lst.de>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4/5] mm/vmalloc: remove unmap_kernel_range
Date: Tue, 26 Jan 2021 07:38:51 +0100 [thread overview]
Message-ID: <20210126063851.GD26674@lst.de> (raw)
In-Reply-To: <20210126045404.2492588-5-npiggin@gmail.com>
On Tue, Jan 26, 2021 at 02:54:03PM +1000, Nicholas Piggin wrote:
> This is a shim around vunmap_range, get rid of it.
>
> Move the main API comment from the _noflush variant to the normal
> variant, and make _noflush internal to mm/.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-01-26 11:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 4:53 [PATCH 0/5] mm/vmalloc: cleanup after hugepage series Nicholas Piggin
2021-01-26 4:54 ` [PATCH 1/5] mm/vmalloc: remove map_kernel_range Nicholas Piggin
2021-01-26 6:37 ` Christoph Hellwig
2021-01-26 4:54 ` [PATCH 2/5] kernel/dma: remove unnecessary unmap_kernel_range Nicholas Piggin
2021-01-26 6:38 ` Christoph Hellwig
2021-01-26 22:08 ` Konrad Rzeszutek Wilk
2021-01-27 7:10 ` Christoph Hellwig
2021-01-27 23:44 ` Nicholas Piggin
2021-01-26 4:54 ` [PATCH 3/5] powerpc/xive: " Nicholas Piggin
2021-01-26 6:38 ` Christoph Hellwig
2021-01-26 7:25 ` Cédric Le Goater
2021-01-26 4:54 ` [PATCH 4/5] mm/vmalloc: remove unmap_kernel_range Nicholas Piggin
2021-01-26 6:38 ` Christoph Hellwig [this message]
2021-01-26 4:54 ` [PATCH 5/5] mm/vmalloc: improve allocation failure error messages Nicholas Piggin
2021-01-26 6:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126063851.GD26674@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).