[PATCH] ntp: use memset and offsetof init

* [PATCH] ntp: use memset and offsetof init
@ 2021-01-20  2:51 Yejune Deng
  2021-01-20  9:32 ` [kbuild] " Dan Carpenter
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Yejune Deng @ 2021-01-20  2:51 UTC (permalink / raw)
  To: john.stultz, tglx, sboyd; +Cc: linux-kernel, yejune.deng

In pps_fill_timex(), use memset and offsetof instead of '= 0'.

Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
 kernel/time/ntp.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 87389b9e21ab..3416c0381104 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -225,14 +225,11 @@ static inline int is_error_status(int status)
 static inline void pps_fill_timex(struct __kernel_timex *txc)
 {
 	/* PPS is not implemented, so these are zero */
-	txc->ppsfreq	   = 0;
-	txc->jitter	   = 0;
-	txc->shift	   = 0;
-	txc->stabil	   = 0;
-	txc->jitcnt	   = 0;
-	txc->calcnt	   = 0;
-	txc->errcnt	   = 0;
-	txc->stbcnt	   = 0;
+	int offset, len;
+
+	offset = offsetof(struct __kernel_timex, ppsfreq);
+	len    = offsetof(struct __kernel_timex, tai) - offset;
+	memset(txc + offset, 0, len);
 }
 
 #endif /* CONFIG_NTP_PPS */
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread