linux-next: Fixes tag needs some work in the amdgpu tree

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

Hi all,

In commit

  289970f0be61 ("drm/amd/display: Fix unused variable warning")

Fixes tag

  Fixes: e177af8a43da ("drm/amd/display: Fix deadlock during gpu reset v3")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  540359b2e8a4 ("drm/amd/display: hpd rx irq not working with eDP interface")

Fixes tag

  Fixes: 11ec7d8f2263 ("drm/amd/display: Allow individual control of eDP hotplug support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ab144f0b4ad6 ("drm/amd/display: Allow individual control of eDP hotplug support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

Hi all,

In commit

  b2d7ff0d8741 ("drm/amd/pm/smu7: move variables to where they are used")

Fixes tag

  Fixes: 711d3c39503b ("drm/amd/pm: fulfill powerplay peak profiling mode shader/memory clock settings")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: b1a9557a7d00 ("drm/amd/pm: fulfill powerplay peak profiling mode shader/memory clock settings")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

Hi all,

In commits

  41a2d4df3d72 ("drm/amd/display: Fix __nedf2 undefined for 32 bit compilation")
  916ae9cc5385 ("drm/amd/display: Fix __muldf3 undefined for 32 bit compilation")
  f20eb84561de ("drm/amd/display: Fix __floatunsidf undefined for 32 bit compilation")

Fixes tag

  Fixes: 9b79abf79c414 ("drm/amd/display: add CLKMGR changes for DCN32/321")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")

In commit

  204b022bcbbf ("drm/amd/display: Fix __umoddi3 undefined for 32 bit compilation")

Fixes tag

  Fixes: 9b0e0d433f74 ("drm/amd/display: Add dependant changes for DCN32/321")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d3dfceb58de5 ("drm/amd/display: Add dependant changes for DCN32/321")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Alex Deucher]

Fixed.  Sorry for the noise.

Alex

On Thu, Jun 30, 2022 at 7:09 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commits
>
>   41a2d4df3d72 ("drm/amd/display: Fix __nedf2 undefined for 32 bit compilation")
>   916ae9cc5385 ("drm/amd/display: Fix __muldf3 undefined for 32 bit compilation")
>   f20eb84561de ("drm/amd/display: Fix __floatunsidf undefined for 32 bit compilation")
>
> Fixes tag
>
>   Fixes: 9b79abf79c414 ("drm/amd/display: add CLKMGR changes for DCN32/321")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
>
> In commit
>
>   204b022bcbbf ("drm/amd/display: Fix __umoddi3 undefined for 32 bit compilation")
>
> Fixes tag
>
>   Fixes: 9b0e0d433f74 ("drm/amd/display: Add dependant changes for DCN32/321")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: d3dfceb58de5 ("drm/amd/display: Add dependant changes for DCN32/321")
>
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hi all,

In commit

  4768e2f5653e ("drm/amd/display: dml: move some variables to heap")

Fixes tag

  Fixes: d03037269bf2 ("drm/amd/display: DML changes for DCN32/321")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: dda4fb85e433 ("drm/amd/display: DML changes for DCN32/321")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi all,

On Sat, 11 Jun 2022 19:55:13 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> In commit
> 
>   4768e2f5653e ("drm/amd/display: dml: move some variables to heap")

This is now commit 9a0efb51178c.

> Fixes tag
> 
>   Fixes: d03037269bf2 ("drm/amd/display: DML changes for DCN32/321")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: dda4fb85e433 ("drm/amd/display: DML changes for DCN32/321")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hi all,

In commit

  d9de22f1e392 ("drm/amdkfd: Add format attribute to kfd_smi_event_add")

Fixes tag

  Fixes: 486975669106c3 ("drm/amdkfd: Add SMI add event helper")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d58b8a99cbb8 ("drm/amdkfd: Add SMI add event helper")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi all,

In commit

  d15628d483a5 ("drm/amd/display: Don't fill up the logs")

Fixes tag

  Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 17ce8a6907f7 ("drm/amd/display: Add dsc pre-validation in atomic check")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Luben Tuikov]

In our local branch it is:

    60862e45da3b5a drm/amd/display: Don't fill up the logs
    ...
    Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")

Which exists:

    5898243ba7acdb drm/amd/display: Add dsc pre-validation in atomic check

So maybe something happened in merging, etc.

Regards,
Luben

On 2022-03-02 15:57, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   d15628d483a5 ("drm/amd/display: Don't fill up the logs")
> 
> Fixes tag
> 
>   Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 17ce8a6907f7 ("drm/amd/display: Add dsc pre-validation in atomic check")
> 

Regards,
-- 
Luben

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Alex Deucher]

On Wed, Mar 2, 2022 at 5:11 PM Luben Tuikov <luben.tuikov@amd.com> wrote:
>
> In our local branch it is:
>
>     60862e45da3b5a drm/amd/display: Don't fill up the logs
>     ...
>     Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")
>
> Which exists:
>
>     5898243ba7acdb drm/amd/display: Add dsc pre-validation in atomic check
>
> So maybe something happened in merging, etc.

That's the commit in our development branch, but that doesn't directly
correspond to the -next branch.  I've fixed it up and pushed a new
-next branch.

Alex

>
> Regards,
> Luben
>
> On 2022-03-02 15:57, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   d15628d483a5 ("drm/amd/display: Don't fill up the logs")
> >
> > Fixes tag
> >
> >   Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 17ce8a6907f7 ("drm/amd/display: Add dsc pre-validation in atomic check")
> >
>
> Regards,
> --
> Luben

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi all,

In commit

  41bea173d9b2 ("drm/amd/pm: drm/amd/pm: disable GetPptLimit message in sriov mode")

Fixes tag

  Fixes: f3527a6483fbcc ("drm/amd/pm: Enable sysfs required by rocm-smi toolfor One VF mode")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Hi all,

In commit

  69bba523d97a ("drm/amdgpu: Fix kernel compilation; style")

Fixes tag

  Fixes: 1b08dfb889b2c5 ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Thus:

Fixes: 1b08dfb889b2 ("drm/amdgpu: remove gart.ready flag")

or

Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Luben Tuikov]

Not sure what to do with this, because in our tree, I see this:

commit 824c2051039dfc
Author: shaoyunl <shaoyun.liu@amd.com>
Date:   Thu Jan 20 10:39:41 2022 -0500

    drm/amdgpu: Disable FRU EEPROM access for SRIOV


And this is what I used.

Regards,
Luben


On 2022-01-25 17:40, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   69bba523d97a ("drm/amdgpu: Fix kernel compilation; style")
>
> Fixes tag
>
>   Fixes: 1b08dfb889b2c5 ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
>
> Thus:
>
> Fixes: 1b08dfb889b2 ("drm/amdgpu: remove gart.ready flag")
>
> or
>
> Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
>

Regards,
-- 
Luben

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Alex Deucher]

On Tue, Jan 25, 2022 at 5:59 PM Luben Tuikov <luben.tuikov@amd.com> wrote:
>
> Not sure what to do with this, because in our tree, I see this:
>
> commit 824c2051039dfc
> Author: shaoyunl <shaoyun.liu@amd.com>
> Date:   Thu Jan 20 10:39:41 2022 -0500
>
>     drm/amdgpu: Disable FRU EEPROM access for SRIOV
>
>
> And this is what I used.

I typo-ed it when I fixed it up.  Properly fixed up now.

Alex

>
> Regards,
> Luben
>
>
> On 2022-01-25 17:40, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   69bba523d97a ("drm/amdgpu: Fix kernel compilation; style")
> >
> > Fixes tag
> >
> >   Fixes: 1b08dfb889b2c5 ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
> >
> > has these problem(s):
> >
> >   - Subject does not match target commit subject
> >     Just use
> >       git log -1 --format='Fixes: %h ("%s")'
> >
> > Thus:
> >
> > Fixes: 1b08dfb889b2 ("drm/amdgpu: remove gart.ready flag")
> >
> > or
> >
> > Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
> >
>
> Regards,
> --
> Luben
>

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi all,

In commit

  47b6584b9f43 ("drm/amdgpu: Fix kernel compilation; style")

Fixes tag

  Fixes: 824c2051039dfc ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Luben Tuikov]

Hi Stephen,

In our local tree the SHA1 for the commit which is being fixed is still 824c2051039dfc.

Perhaps there was a cherry-pick or some kind of rewrite or something.

Regards,
Luben

On 2022-01-23 00:41, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   47b6584b9f43 ("drm/amdgpu: Fix kernel compilation; style")
>
> Fixes tag
>
>   Fixes: 824c2051039dfc ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
>

Regards,
-- 
Luben

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Hi all,

In commit

  e2ec2136832f ("drm/amd/display: Fix OLED brightness control on eDP")

Fixes tag

  Fixes: 7fd13baeb7a3a4 ("drm/amd/display: add support for multiple backlights")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Also, please keep all the commit message tags toether at the end of the
commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  d6874a709faa ("drm/amdgpu: fix uvd crash on Polaris12 during driver unloading")

Fixes tag

  Fixes: cdccf1ffe1a3 ("drm/amdgpu: Fix crash on device remove/driver unload")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d82e2c249c8f ("drm/amdgpu: Fix crash on device remove/driver unload")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  8bc3824f0ee2 ("drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not set")

Fixes tag

  Fixes: 41724ea273cdda ("drm/amd/display: Add DP 2.0 MST DM Support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

  39b3c728e5ca ("drm/amd/display: Add DP 2.0 MST DM Support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  8e4826da95bc ("drm/amd/display: Fix white screen page fault for gpuvm")

Fixes tag

  Fixes: 64b1d0e8d50 ("drm/amd/display: Add DCN3.1 HWSEQ")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi all,

In commit

  b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")

Fixes tag

  Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)

has these problem(s):

  - Subject has leading but no trailing quotes
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Dan Carpenter]

On Fri, Jul 09, 2021 at 07:37:11AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")
> 
> Fixes tag
> 
>   Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Oops.  Sorry.  I've created a fixes.sh like you say.

#!/bin/bash

git log -1 --format='Fixes: %h ("%s")' $*

regards,
dan carpenter

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Alex Deucher]

On Fri, Jul 9, 2021 at 3:43 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Fri, Jul 09, 2021 at 07:37:11AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")
> >
> > Fixes tag
> >
> >   Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)
> >
> > has these problem(s):
> >
> >   - Subject has leading but no trailing quotes
> >     Just use
> >       git log -1 --format='Fixes: %h ("%s")'
>
> Oops.  Sorry.  I've created a fixes.sh like you say.
>

Fixed up locally.

Alex

> #!/bin/bash
>
> git log -1 --format='Fixes: %h ("%s")' $*
>
> regards,
> dan carpenter

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

In commit

  56b019f8eda0 ("drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB")

Fixes tag

  Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer

has these problem(s):

  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Michel Dänzer]

On 2021-06-03 12:39 a.m., Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    56b019f8eda0 ("drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB")
> 
> Fixes tag
> 
>    Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
> 
> has these problem(s):
> 
>    - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Got it.


-- 
Earthling Michel Dänzer               |               https://redhat.com
Libre software enthusiast             |             Mesa and X developer

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hi all,

In commit

  d4378f172385 ("drm/amdgpu/display: fix warning when CONFIG_DRM_AMD_DC_DCN is not defined")

Fixes tag

  Fixes: 77a49c458931 ("drm/amd/display: Support for DMUB AUX")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 81927e2808be ("drm/amd/display: Support for DMUB AUX")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

In commit

  337142ee10ca ("drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not defined")

Fixes tag

  Fixes: 77a49c458931 ("drm/amd/display: Support for DMUB AUX")

has these problem(s):

  - Target SHA1 does not exist

Maybe you ment

Fixes: 81927e2808be ("drm/amd/display: Support for DMUB AUX")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

In commit

  0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")

Fixes tag

  Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[David Ward]

On 5/10/21 6:42 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>    0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")
>
> Fixes tag
>
>    Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")
>
> has these problem(s):
>
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'
>
> Maybe you meant
>
> Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")
>
My apologies. The correct hash is in fact 9037246bb2da. (Commit 
a193ed2094ba introduced HDCP handling in amdgpu_pm, but did not include 
the sysfs file.) It seems I inadvertently copied the wrong hash when 
preparing the commit message.

Please let me know if I need to resubmit this patch.

Thank you,

David

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Alex Deucher]

I'll fix it up.

Alex

On Mon, May 10, 2021 at 7:08 PM David Ward <david.ward@gatech.edu> wrote:
>
> On 5/10/21 6:42 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >    0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")
> >
> > Fixes tag
> >
> >    Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")
> >
> > has these problem(s):
> >
> >    - Subject does not match target commit subject
> >      Just use
> >       git log -1 --format='Fixes: %h ("%s")'
> >
> > Maybe you meant
> >
> > Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")
> >
> My apologies. The correct hash is in fact 9037246bb2da. (Commit
> a193ed2094ba introduced HDCP handling in amdgpu_pm, but did not include
> the sysfs file.) It seems I inadvertently copied the wrong hash when
> preparing the commit message.
>
> Please let me know if I need to resubmit this patch.
>
> Thank you,
>
> David
>
>

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  47c45c39d1a4 ("drm/amdkfd: Use a new capability bit for SRAM ECC")

Fixes tag

  Fixes: 7ec177bdcfc1 ("drm/amdkfd: fix set kfd node ras properties value")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant:

Fixes: 5436ab94cd94 ("drm/amdkfd: fix set kfd node ras properties value")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi all,

In commit

  8f76b1bbe713 ("drm/amdgpu/pm: fix the fan speed in fan1_input in manual mode for navi1x")

Fixes tag

  Fixes: 3033e9f1c2de ("drm/amdgpu/swsmu: handle manual fan readback on SMU11")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: f6eb433954bf ("drm/amdgpu/swsmu: handle manual fan readback on SMU11")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  bc6058294cb2 ("drm/amd/display: [FIX] update clock under two conditions")

Fixes tag

  Fixes: 06f9b1475d98 ("drm/amd/display: update clock when non-seamless boot stream exist")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 598c13b21e25 ("drm/amd/display: update clock when non-seamless boot stream exist")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  82d6b9745744 ("drm/amdgpu/debugfs: fix memory leak when amdgpu_virt_enable_access_debugfs failed")

Fixes tag

  Fixes: 95a2f917387a2 ("drm/amdgpu: restrict debugfs register accessunder SR-IOV")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi all,

In commit

  31fba61da070 ("drm/amdgpu/pm: don't bail for in_suspend")

Fixes tag

  Fixes: f7c8d853b029df ("drm/amdgpu/pm: return an error during GPU reset or suspend")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 2d0021bb7157 ("drm/amdgpu/pm: return an error during GPU reset or suspend")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

In commit

  caa01659028a ("drm/amdgpu: move umc offset to one new header file for Arcturus")

Fixes tag

  Fixes: 9686563c4c42 drm/amdgpu: Added RAS UMC error query support for Arcturus

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 4cf781c24c3b ("drm/amdgpu: Added RAS UMC error query support for Arcturus")

Also, please keep all the tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the amdgpu tree

[Chen, Guchun]

[AMD Official Use Only - Internal Distribution Only]

Hi Stephen,

Sorry for the inconvenience. How I can fix this?

Regards,
Guchun

-----Original Message-----
From: Stephen Rothwell <sfr@canb.auug.org.au> 
Sent: Thursday, December 19, 2019 5:26 AM
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Chen, Guchun <Guchun.Chen@amd.com>
Subject: linux-next: Fixes tag needs some work in the amdgpu tree

Hi all,

In commit

  caa01659028a ("drm/amdgpu: move umc offset to one new header file for Arcturus")

Fixes tag

  Fixes: 9686563c4c42 drm/amdgpu: Added RAS UMC error query support for Arcturus

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 4cf781c24c3b ("drm/amdgpu: Added RAS UMC error query support for Arcturus")

Also, please keep all the tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[Alex Deucher]

On Wed, Dec 18, 2019 at 8:22 PM Chen, Guchun <Guchun.Chen@amd.com> wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi Stephen,
>
> Sorry for the inconvenience. How I can fix this?
>

Already fixed.

Alex

> Regards,
> Guchun
>
> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Thursday, December 19, 2019 5:26 AM
> To: Alex Deucher <alexdeucher@gmail.com>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Chen, Guchun <Guchun.Chen@amd.com>
> Subject: linux-next: Fixes tag needs some work in the amdgpu tree
>
> Hi all,
>
> In commit
>
>   caa01659028a ("drm/amdgpu: move umc offset to one new header file for Arcturus")
>
> Fixes tag
>
>   Fixes: 9686563c4c42 drm/amdgpu: Added RAS UMC error query support for Arcturus
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: 4cf781c24c3b ("drm/amdgpu: Added RAS UMC error query support for Arcturus")
>
> Also, please keep all the tags together at the end of the commit message.
>
> --
> Cheers,
> Stephen Rothwell

RE: linux-next: Fixes tag needs some work in the amdgpu tree

[Chen, Guchun]

Thanks Alex and Stephen.
I will be aware of this next time. Sorry for the inconvenience again.

Regards,
Guchun

-----Original Message-----
From: Alex Deucher <alexdeucher@gmail.com> 
Sent: Thursday, December 19, 2019 12:47 PM
To: Chen, Guchun <Guchun.Chen@amd.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>; Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

On Wed, Dec 18, 2019 at 8:22 PM Chen, Guchun <Guchun.Chen@amd.com> wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi Stephen,
>
> Sorry for the inconvenience. How I can fix this?
>

Already fixed.

Alex

> Regards,
> Guchun
>
> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Thursday, December 19, 2019 5:26 AM
> To: Alex Deucher <alexdeucher@gmail.com>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Chen, Guchun <Guchun.Chen@amd.com>
> Subject: linux-next: Fixes tag needs some work in the amdgpu tree
>
> Hi all,
>
> In commit
>
>   caa01659028a ("drm/amdgpu: move umc offset to one new header file for Arcturus")
>
> Fixes tag
>
>   Fixes: 9686563c4c42 drm/amdgpu: Added RAS UMC error query support for Arcturus
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: 4cf781c24c3b ("drm/amdgpu: Added RAS UMC error query support for Arcturus")
>
> Also, please keep all the tags together at the end of the commit message.
>
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

Hi all,

In commit

  1b8b896f1ea5 ("drm/amd/display: Null check aconnector in event_property_validate")

Fixes tag

  Fixes: cc5dae9f6286 ("drm/amd/display: Refactor HDCP to handle multiple

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b1abe5586ffc ("drm/amd/display: Refactor HDCP to handle multiple displays per link")

Also, please do not split Fixes tags over more than one line and keep
them with the rest of the tags at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  8c9f69bc5cc4 ("drm/amdgpu: fix build error without CONFIG_HSA_AMD")

Fixes tag

  Fixes: 1abb680ad371 ("drm/amdgpu: disable gfxoff while use no H/W scheduling policy")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: aa978594cf7f ("drm/amdgpu: disable gfxoff while use no H/W scheduling policy")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the amdgpu tree

[S, Shirish]

Hi Stephen,


On 10/3/2019 3:41 AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>    8c9f69bc5cc4 ("drm/amdgpu: fix build error without CONFIG_HSA_AMD")
>
> Fixes tag
>
>    Fixes: 1abb680ad371 ("drm/amdgpu: disable gfxoff while use no H/W scheduling policy")
>
> has these problem(s):
>
>    - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: aa978594cf7f ("drm/amdgpu: disable gfxoff while use no H/W scheduling policy")

Yes, I meant "aa978594cf7f".

Regards,

Shirish S

-- 
Regards,
Shirish S

linux-next: Fixes tag needs some work in the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Hi Alex,

Commits

  b208c3a940b9 ("drm/amdkfd: avoid HMM change cause circular lock")
  8a3397a108e5 ("drm/amdgpu: use HMM callback to replace mmu notifier")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]