* [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable
@ 2021-01-26 20:55 David E. Box
2021-01-26 20:55 ` [PATCH 2/3] platform/x86: intel_pmt_telemetry: Add dependency on MFD_INTEL_PMT David E. Box
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David E. Box @ 2021-01-26 20:55 UTC (permalink / raw)
To: mark.gross, hdegoede, lee.jones, torvalds
Cc: David E. Box, linux-kernel, platform-driver-x86
Fix error in Kconfig that exposed INTEL_PMT_CLASS as a user selectable
option. It is already selected by INTEL_PMT_TELEMETRY and
INTEL_PMT_CRASHLOG which are user selectable.
Fixes: e2729113ce66 ("platform/x86: Intel PMT class driver")
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 91e6176cdfbd..af75c3342c06 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1369,7 +1369,7 @@ config INTEL_PMC_CORE
- MPHY/PLL gating status (Sunrisepoint PCH only)
config INTEL_PMT_CLASS
- tristate "Intel Platform Monitoring Technology (PMT) Class driver"
+ tristate
help
The Intel Platform Monitoring Technology (PMT) class driver provides
the basic sysfs interface and file hierarchy uses by PMT devices.
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] platform/x86: intel_pmt_telemetry: Add dependency on MFD_INTEL_PMT
2021-01-26 20:55 [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable David E. Box
@ 2021-01-26 20:55 ` David E. Box
2021-01-26 20:55 ` [PATCH 3/3] platform/x86: intel_pmt_crashlog: " David E. Box
2021-02-03 11:00 ` [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: David E. Box @ 2021-01-26 20:55 UTC (permalink / raw)
To: mark.gross, hdegoede, lee.jones, torvalds
Cc: David E. Box, linux-kernel, platform-driver-x86
All devices that expose Intel Platform Monitoring Technology (PMT)
telemetry are currently owned by the intel_pmt MFD driver. Therefore make
the telemetry driver depend on the MFD driver for build.
Fixes: 68fe8e6e2c4b ("platform/x86: Intel PMT Telemetry capability driver")
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index af75c3342c06..9948c5f4928d 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1382,6 +1382,7 @@ config INTEL_PMT_CLASS
config INTEL_PMT_TELEMETRY
tristate "Intel Platform Monitoring Technology (PMT) Telemetry driver"
+ depends on MFD_INTEL_PMT
select INTEL_PMT_CLASS
help
The Intel Platform Monitory Technology (PMT) Telemetry driver provides
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] platform/x86: intel_pmt_crashlog: Add dependency on MFD_INTEL_PMT
2021-01-26 20:55 [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable David E. Box
2021-01-26 20:55 ` [PATCH 2/3] platform/x86: intel_pmt_telemetry: Add dependency on MFD_INTEL_PMT David E. Box
@ 2021-01-26 20:55 ` David E. Box
2021-02-03 11:00 ` [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: David E. Box @ 2021-01-26 20:55 UTC (permalink / raw)
To: mark.gross, hdegoede, lee.jones, torvalds
Cc: David E. Box, linux-kernel, platform-driver-x86
All devices that expose Intel Platform Monitoring Technology (PMT)
crashlog are currently owned by the intel_pmt MFD driver. Therefore make
the crashlog driver depend on the MFD driver for build.
Fixes: 5ef9998c96b0 ("platform/x86: Intel PMT Crashlog capability driver")
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9948c5f4928d..ac4125ec0660 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1394,6 +1394,7 @@ config INTEL_PMT_TELEMETRY
config INTEL_PMT_CRASHLOG
tristate "Intel Platform Monitoring Technology (PMT) Crashlog driver"
+ depends on MFD_INTEL_PMT
select INTEL_PMT_CLASS
help
The Intel Platform Monitoring Technology (PMT) crashlog driver provides
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable
2021-01-26 20:55 [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable David E. Box
2021-01-26 20:55 ` [PATCH 2/3] platform/x86: intel_pmt_telemetry: Add dependency on MFD_INTEL_PMT David E. Box
2021-01-26 20:55 ` [PATCH 3/3] platform/x86: intel_pmt_crashlog: " David E. Box
@ 2021-02-03 11:00 ` Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2021-02-03 11:00 UTC (permalink / raw)
To: David E. Box, mark.gross, lee.jones, torvalds
Cc: linux-kernel, platform-driver-x86
Hi,
On 1/26/21 9:55 PM, David E. Box wrote:
> Fix error in Kconfig that exposed INTEL_PMT_CLASS as a user selectable
> option. It is already selected by INTEL_PMT_TELEMETRY and
> INTEL_PMT_CRASHLOG which are user selectable.
>
> Fixes: e2729113ce66 ("platform/x86: Intel PMT class driver")
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 91e6176cdfbd..af75c3342c06 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1369,7 +1369,7 @@ config INTEL_PMC_CORE
> - MPHY/PLL gating status (Sunrisepoint PCH only)
>
> config INTEL_PMT_CLASS
> - tristate "Intel Platform Monitoring Technology (PMT) Class driver"
> + tristate
> help
> The Intel Platform Monitoring Technology (PMT) class driver provides
> the basic sysfs interface and file hierarchy uses by PMT devices.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-03 11:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 20:55 [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable David E. Box
2021-01-26 20:55 ` [PATCH 2/3] platform/x86: intel_pmt_telemetry: Add dependency on MFD_INTEL_PMT David E. Box
2021-01-26 20:55 ` [PATCH 3/3] platform/x86: intel_pmt_crashlog: " David E. Box
2021-02-03 11:00 ` [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).