From: Oliver Graute <oliver.graute@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Marco Felsch <m.felsch@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD
Date: Tue, 26 Jan 2021 22:17:23 +0100 [thread overview]
Message-ID: <20210126211723.GA17512@portage> (raw)
In-Reply-To: <CAOMZO5A99AJ9NVUmbFr3pE2jxXnQnGNZ+00LHtBTtG3f2mye8w@mail.gmail.com>
On 26/01/21, Fabio Estevam wrote:
> Hi Oliver,
>
> On Mon, Jan 25, 2021 at 7:17 PM Oliver Graute <oliver.graute@gmail.com> wrote:
>
> > I would prefer mine, because I got a wrong colored penguin on bootup
> > with yours :-)
The wrong colored Tux is caused by the bus_format:
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
So I assume I need another bus_format here.
>
> I have originally passed .bpc = 8, but looking at the panel datasheet,
> this should be:
> .bpc = 6 instead.
yes this is right. I found it too in the datasheet. I'll fix it in next
version of the patch.
>
> In your patch, you pass the timing parameters three times, but they
> are all the same.
>
> Usually, it is meant to be: minimal, typical, maximum values.
yes because on a lot of entries there is just the typical value and no min
and max. But not on all of them.
Best regards,
Oliver
next prev parent reply other threads:[~2021-01-27 3:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 12:44 [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD Oliver Graute
2021-01-08 21:43 ` Oliver Graute
2021-01-09 19:27 ` Fabio Estevam
2021-01-10 15:35 ` Oliver Graute
2021-01-10 16:22 ` Fabio Estevam
2021-01-10 20:06 ` Oliver Graute
2021-01-10 23:50 ` Fabio Estevam
2021-01-16 12:48 ` Oliver Graute
2021-01-16 13:44 ` Fabio Estevam
2021-01-25 21:29 ` Oliver Graute
2021-01-25 21:36 ` Fabio Estevam
2021-01-25 22:17 ` Oliver Graute
2021-01-26 11:17 ` Fabio Estevam
2021-01-26 21:17 ` Oliver Graute [this message]
2021-01-15 14:31 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126211723.GA17512@portage \
--to=oliver.graute@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).