From: "Paul E. McKenney" <paulmck@kernel.org> To: Yury Norov <yury.norov@gmail.com> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, lizefan@huawei.com, Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, josh@joshtriplett.org, Peter Zijlstra <peterz@infradead.org>, fweisbec@gmail.com, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs= Date: Tue, 26 Jan 2021 14:17:55 -0800 [thread overview] Message-ID: <20210126221755.GH2743@paulmck-ThinkPad-P72> (raw) In-Reply-To: <CAAH8bW_kiReeYrXmFp=2o_YkOitsSrtN9evKaR6SWdZk8TNuoQ@mail.gmail.com> On Tue, Jan 26, 2021 at 01:36:23PM -0800, Yury Norov wrote: > On Tue, Jan 26, 2021 at 9:12 AM Paul Gortmaker > <paul.gortmaker@windriver.com> wrote: > > > > With the core bitmap support now accepting "N" as a placeholder for > > the end of the bitmap, "all" can be represented as "0-N" and has the > > advantage of not being specific to RCU (or any other subsystem). > > > > So deprecate the use of "all" by removing documentation references > > to it. The support itself needs to remain for now, since we don't > > know how many people out there are using it currently, but since it > > is in an __init area anyway, it isn't worth losing sleep over. > > > > Cc: Yury Norov <yury.norov@gmail.com> > > Cc: Peter Zijlstra <peterz@infradead.org> > > Cc: "Paul E. McKenney" <paulmck@kernel.org> > > Cc: Josh Triplett <josh@joshtriplett.org> > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > > --- > > Documentation/admin-guide/kernel-parameters.txt | 4 +--- > > kernel/rcu/tree_plugin.h | 6 ++---- > > 2 files changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > > index a10b545c2070..a116c0ff0a91 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -4037,9 +4037,7 @@ > > see CONFIG_RAS_CEC help text. > > > > rcu_nocbs= [KNL] > > - The argument is a cpu list, as described above, > > - except that the string "all" can be used to > > - specify every CPU on the system. > > + The argument is a cpu list, as described above. > > > > In kernels built with CONFIG_RCU_NOCB_CPU=y, set > > the specified list of CPUs to be no-callback CPUs. > > diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h > > index 7e291ce0a1d6..56788dfde922 100644 > > --- a/kernel/rcu/tree_plugin.h > > +++ b/kernel/rcu/tree_plugin.h > > @@ -1463,14 +1463,12 @@ static void rcu_cleanup_after_idle(void) > > > > /* > > * Parse the boot-time rcu_nocb_mask CPU list from the kernel parameters. > > - * The string after the "rcu_nocbs=" is either "all" for all CPUs, or a > > - * comma-separated list of CPUs and/or CPU ranges. If an invalid list is > > - * given, a warning is emitted and all CPUs are offloaded. > > + * If the list is invalid, a warning is emitted and all CPUs are offloaded. > > */ > > static int __init rcu_nocb_setup(char *str) > > { > > alloc_bootmem_cpumask_var(&rcu_nocb_mask); > > - if (!strcasecmp(str, "all")) > > + if (!strcasecmp(str, "all")) /* legacy: use "0-N" instead */ > > I think 'all' and 'none' is a good idea. It's simple and convenient. > But if you don't > like it, can you please at least put this comment in system log using > WARN_ON_ONCE(). It's quite possible that Linux users don't read source code > comments. Please leave it silent. This has been available to RCU users for quite some time, so suddenly spewing warnings at all of them is a bit unfriendly. The extra code is negligible, and the documentation will guide people more gently in the right direction. Plus I am the one who would end up receiving complaints about the warnings, and I have much better things to do with my time. Thanx, Paul > > cpumask_setall(rcu_nocb_mask); > > else > > if (cpulist_parse(str, rcu_nocb_mask)) { > > -- > > 2.17.1 > >
next prev parent reply other threads:[~2021-01-27 3:43 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-26 17:11 [PATCH v3 0/8] support for bitmap (and hence CPU) list "N" abbreviation Paul Gortmaker 2021-01-26 17:11 ` [PATCH 1/8] lib: test_bitmap: clearly separate ERANGE from EINVAL tests Paul Gortmaker 2021-01-26 21:04 ` Andy Shevchenko 2021-01-27 7:21 ` Paul Gortmaker 2021-01-26 17:11 ` [PATCH 2/8] lib: test_bitmap: add more start-end:offset/len tests Paul Gortmaker 2021-01-26 21:11 ` Andy Shevchenko 2021-01-27 3:03 ` Yury Norov 2021-01-26 17:11 ` [PATCH 3/8] lib: bitmap: fold nbits into region struct Paul Gortmaker 2021-01-26 21:16 ` Andy Shevchenko 2021-01-26 21:18 ` Andy Shevchenko 2021-01-27 8:02 ` Paul Gortmaker 2021-01-28 0:47 ` Yury Norov 2021-01-28 10:17 ` Andy Shevchenko 2021-01-27 3:08 ` Yury Norov 2021-01-26 17:11 ` [PATCH 4/8] lib: bitmap: move ERANGE check from set_region to check_region Paul Gortmaker 2021-01-26 21:19 ` Andy Shevchenko 2021-01-27 3:12 ` Yury Norov 2021-01-26 17:11 ` [PATCH 5/8] lib: bitmap_getnum: separate arg into region and field Paul Gortmaker 2021-01-26 21:23 ` Andy Shevchenko 2021-01-27 2:58 ` Yury Norov 2021-01-27 8:38 ` Paul Gortmaker 2021-01-26 17:11 ` [PATCH 6/8] lib: bitmap: support "N" as an alias for size of bitmap Paul Gortmaker 2021-01-26 21:37 ` Andy Shevchenko 2021-01-26 21:41 ` Andy Shevchenko 2021-01-27 17:57 ` Yury Norov 2021-01-27 8:20 ` Paul Gortmaker 2021-01-26 17:11 ` [PATCH 7/8] lib: test_bitmap: add tests for "N" alias Paul Gortmaker 2021-01-26 17:11 ` [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs= Paul Gortmaker 2021-01-26 21:36 ` Yury Norov 2021-01-26 22:17 ` Paul E. McKenney [this message] 2021-01-26 22:27 ` [PATCH v3 0/8] support for bitmap (and hence CPU) list "N" abbreviation Yury Norov 2021-01-27 9:12 ` Paul Gortmaker 2021-02-09 22:58 [PATCH v4 " Paul Gortmaker 2021-02-09 22:59 ` [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs= Paul Gortmaker 2021-02-21 8:08 [PATCH v5 0/8] support for bitmap (and hence CPU) list "N" abbreviation Paul Gortmaker 2021-02-21 8:08 ` [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs= Paul Gortmaker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210126221755.GH2743@paulmck-ThinkPad-P72 \ --to=paulmck@kernel.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=fweisbec@gmail.com \ --cc=josh@joshtriplett.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=lizefan@huawei.com \ --cc=mingo@kernel.org \ --cc=paul.gortmaker@windriver.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=yury.norov@gmail.com \ --subject='Re: [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs=' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).