From: Vladimir Oltean <olteanv@gmail.com>
To: Lorenzo Carletti <lorenzo.carletti98@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] net: dsa: rtl8366rb: standardize init jam tables
Date: Wed, 27 Jan 2021 00:37:00 +0200 [thread overview]
Message-ID: <20210126223700.d3wdlf264ox7ea2w@skbuf> (raw)
In-Reply-To: <20210126222805.fd7pzt7zenl72mmo@skbuf>
On Wed, Jan 27, 2021 at 12:28:05AM +0200, Vladimir Oltean wrote:
> > So, allow me to explain. The kernel jams every "i + 1" value in the array
> > tables into the registers at " i", and then increments "i" by 2.
> > These can be seen as [n][2] matrixes, just like the ethernet one.
> > Having the arrays converted to matrixes can help visualize which
> > value is jammed where, or at least that's how I feel like it is.
> > I know it's not a big change...
>
> Got it, thanks. It is better, in fact, once you get over that whole
> 0xBE00 thing...
If you really want beautiful code, I guess you could create a structure
with two fields:
struct rtl8366rb_jam_table_entry {
u16 addr;
u16 val;
};
and then convert those ugly looking matrix definitions:
u16 (*jam_table)[2]
with:
struct rtl8366rb_jam_table_entry *jam_table
and this:
ret = regmap_write(smi->map,
jam_table[i][0],
jam_table[i][1]);
with this:
ret = regmap_write(smi->map,
jam_table[i].addr,
jam_table[i].val);
The memory footprint would be exactly the same, and the struct
initializers would look exactly the same as your current array
declarations.
next prev parent reply other threads:[~2021-01-27 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 4:56 [PATCH 0/1] net: dsa: rtl8366rb: change type of jam tables Lorenzo Carletti
2021-01-25 4:56 ` [PATCH 1/1] net: dsa: rtl8366rb: standardize init " Lorenzo Carletti
2021-01-26 21:08 ` Vladimir Oltean
2021-01-26 21:21 ` Vladimir Oltean
2021-01-26 21:38 ` Vladimir Oltean
[not found] ` <CABRCJOSzm6s3hv17KFXMZigJjuBEidLLAM8+dqrGk9xTE=FkcQ@mail.gmail.com>
2021-01-26 22:28 ` Vladimir Oltean
2021-01-26 22:37 ` Vladimir Oltean [this message]
2021-01-26 21:40 ` Linus Walleij
2021-01-26 21:41 ` Linus Walleij
2021-01-28 16:07 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126223700.d3wdlf264ox7ea2w@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.carletti98@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).