From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, lizefan@huawei.com,
mingo@kernel.org, tglx@linutronix.de, josh@joshtriplett.org,
yury.norov@gmail.com, peterz@infradead.org, paulmck@kernel.org,
fweisbec@gmail.com, linux@rasmusvillemoes.dk
Subject: Re: [PATCH 1/8] lib: test_bitmap: clearly separate ERANGE from EINVAL tests.
Date: Wed, 27 Jan 2021 02:21:40 -0500 [thread overview]
Message-ID: <20210127072139.GD23530@windriver.com> (raw)
In-Reply-To: <YBCD+czt+6IjAymI@smile.fi.intel.com>
[Re: [PATCH 1/8] lib: test_bitmap: clearly separate ERANGE from EINVAL tests.] On 26/01/2021 (Tue 23:04) Andy Shevchenko wrote:
> On Tue, Jan 26, 2021 at 12:11:34PM -0500, Paul Gortmaker wrote:
> > This block of tests was meant to find/flag incorrect use of the ":"
> > and "/" separators (syntax errors) and invalid (zero) group len.
> >
> > However they were specified with an 8 bit width and 32 bit operations,
> > so they really contained two errors (EINVAL and ERANGE).
> >
> > Promote them to 32 bit so it is clear what they are meant to target,
> > and then add tests specific for ERANGE (no syntax errors, just doing
> > 32bit op on 8 bit width, plus a typical 9-on-8 fencepost error).
> >
> > Note that the remaining "10-1" on 8 is left as-is, since that captures
> > the fact that we check for (r->start > r->end) ---> EINVAL before we
> > check for (r->end >= nbits) ---> ERANGE. If the code is ever re-ordered
> > then this test will pick up the mismatched errno value.
>
> I didn't get the last statement. You meant code in the bitmap library itself,
> and not in the test cases? Please, clarify this somehow.
It probably wasn't worth a mention at all, as that test in question was
left unchanged; but yes - it was a reference to the ordering of the
sanity checks in the bitmap code itself and not the test order. I'll
simply delete the confusing "10-1" paragraph/comment.
> I don't really much care, since it's not a tricky commit, but it might be split
> to two or three separated ones. Anyway, feel free to add
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Since you mentioned it, I assume you would prefer it. So I will make
the 8 --> 32 change in one commit, and add the two new ERANGE tests in
another subsequent commit.
Thanks,
Paul.
--
>
> > Cc: Yury Norov <yury.norov@gmail.com>
> > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
> > lib/test_bitmap.c | 16 +++++++++-------
> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> > index 4425a1dd4ef1..3d2cd3b1de84 100644
> > --- a/lib/test_bitmap.c
> > +++ b/lib/test_bitmap.c
> > @@ -337,13 +337,15 @@ static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> >
> > {-EINVAL, "-1", NULL, 8, 0},
> > {-EINVAL, "-0", NULL, 8, 0},
> > - {-EINVAL, "10-1", NULL, 8, 0},
> > - {-EINVAL, "0-31:", NULL, 8, 0},
> > - {-EINVAL, "0-31:0", NULL, 8, 0},
> > - {-EINVAL, "0-31:0/", NULL, 8, 0},
> > - {-EINVAL, "0-31:0/0", NULL, 8, 0},
> > - {-EINVAL, "0-31:1/0", NULL, 8, 0},
> > - {-EINVAL, "0-31:10/1", NULL, 8, 0},
> > + {-EINVAL, "10-1", NULL, 8, 0}, /* (start > end) ; also ERANGE */
> > + {-ERANGE, "8-8", NULL, 8, 0},
> > + {-ERANGE, "0-31", NULL, 8, 0},
> > + {-EINVAL, "0-31:", NULL, 32, 0},
> > + {-EINVAL, "0-31:0", NULL, 32, 0},
> > + {-EINVAL, "0-31:0/", NULL, 32, 0},
> > + {-EINVAL, "0-31:0/0", NULL, 32, 0},
> > + {-EINVAL, "0-31:1/0", NULL, 32, 0},
> > + {-EINVAL, "0-31:10/1", NULL, 32, 0},
> > {-EOVERFLOW, "0-98765432123456789:10/1", NULL, 8, 0},
> >
> > {-EINVAL, "a-31", NULL, 8, 0},
> > --
> > 2.17.1
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2021-01-27 7:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 17:11 [PATCH v3 0/8] support for bitmap (and hence CPU) list "N" abbreviation Paul Gortmaker
2021-01-26 17:11 ` [PATCH 1/8] lib: test_bitmap: clearly separate ERANGE from EINVAL tests Paul Gortmaker
2021-01-26 21:04 ` Andy Shevchenko
2021-01-27 7:21 ` Paul Gortmaker [this message]
2021-01-26 17:11 ` [PATCH 2/8] lib: test_bitmap: add more start-end:offset/len tests Paul Gortmaker
2021-01-26 21:11 ` Andy Shevchenko
2021-01-27 3:03 ` Yury Norov
2021-01-26 17:11 ` [PATCH 3/8] lib: bitmap: fold nbits into region struct Paul Gortmaker
2021-01-26 21:16 ` Andy Shevchenko
2021-01-26 21:18 ` Andy Shevchenko
2021-01-27 8:02 ` Paul Gortmaker
2021-01-28 0:47 ` Yury Norov
2021-01-28 10:17 ` Andy Shevchenko
2021-01-27 3:08 ` Yury Norov
2021-01-26 17:11 ` [PATCH 4/8] lib: bitmap: move ERANGE check from set_region to check_region Paul Gortmaker
2021-01-26 21:19 ` Andy Shevchenko
2021-01-27 3:12 ` Yury Norov
2021-01-26 17:11 ` [PATCH 5/8] lib: bitmap_getnum: separate arg into region and field Paul Gortmaker
2021-01-26 21:23 ` Andy Shevchenko
2021-01-27 2:58 ` Yury Norov
2021-01-27 8:38 ` Paul Gortmaker
2021-01-26 17:11 ` [PATCH 6/8] lib: bitmap: support "N" as an alias for size of bitmap Paul Gortmaker
2021-01-26 21:37 ` Andy Shevchenko
2021-01-26 21:41 ` Andy Shevchenko
2021-01-27 17:57 ` Yury Norov
2021-01-27 8:20 ` Paul Gortmaker
2021-01-26 17:11 ` [PATCH 7/8] lib: test_bitmap: add tests for "N" alias Paul Gortmaker
2021-01-26 17:11 ` [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs= Paul Gortmaker
2021-01-26 21:36 ` Yury Norov
2021-01-26 22:17 ` Paul E. McKenney
2021-01-26 22:27 ` [PATCH v3 0/8] support for bitmap (and hence CPU) list "N" abbreviation Yury Norov
2021-01-27 9:12 ` Paul Gortmaker
2021-02-09 22:58 [PATCH v4 " Paul Gortmaker
2021-02-09 22:59 ` [PATCH 1/8] lib: test_bitmap: clearly separate ERANGE from EINVAL tests Paul Gortmaker
2021-02-21 8:08 [PATCH v5 0/8] support for bitmap (and hence CPU) list "N" abbreviation Paul Gortmaker
2021-02-21 8:08 ` [PATCH 1/8] lib: test_bitmap: clearly separate ERANGE from EINVAL tests Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127072139.GD23530@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).