From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F5F5C433E0 for ; Wed, 27 Jan 2021 21:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF66A64DCC for ; Wed, 27 Jan 2021 21:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236438AbhA0VyB (ORCPT ); Wed, 27 Jan 2021 16:54:01 -0500 Received: from mga09.intel.com ([134.134.136.24]:48633 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234982AbhA0VxC (ORCPT ); Wed, 27 Jan 2021 16:53:02 -0500 IronPort-SDR: 1bpDCo7Ak/dMDUK3T+Y7W63dH8aMJXTVfDqWDnJ5AB0NSNUsu2V9nDdyKTRYPGuvPapwZQjppC fpbvyA4zs/lg== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="180284196" X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="180284196" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 13:52:15 -0800 IronPort-SDR: eMUsAMTAn1/kJKi2+N3WYkgp2WWjSfrhNUEGMZw4T01LBxqqkukZ/UCturgutvXJEvoRl1ZhpB h4jTZtxahTwA== X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="573410519" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.44.59]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 13:52:13 -0800 Date: Wed, 27 Jan 2021 13:52:11 -0800 From: Jesse Brandeburg To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , David Rientjes , Yisen Zhuang , Salil Mehta , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage Message-ID: <20210127135211.00005620@intel.com> In-Reply-To: <20210127201031.98544-1-alobakin@pm.me> References: <20210127201031.98544-1-alobakin@pm.me> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexander Lobakin wrote: > page_is_pfmemalloc() is used mostly by networking drivers to test > if a page can be considered for reusing/recycling. > It doesn't write anything to the struct page itself, so its sole > argument can be constified, as well as the first argument of > skb_propagate_pfmemalloc(). > In Page Pool core code, it can be simply inlined instead. > Most of the callers from NIC drivers were just doppelgangers of > the same condition tests. Derive them into a new common function > do deduplicate the code. This is a useful cleanup! Thanks. For the series: Reviewed-by: Jesse Brandeburg