From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: stefanc@marvell.com
Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com,
linux-kernel@vger.kernel.org, kuba@kernel.org, mw@semihalf.com,
andrew@lunn.ch, atenart@kernel.org
Subject: Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check
Date: Wed, 27 Jan 2021 14:05:53 +0000 [thread overview]
Message-ID: <20210127140552.GM1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <1611747815-1934-20-git-send-email-stefanc@marvell.com>
On Wed, Jan 27, 2021 at 01:43:35PM +0200, stefanc@marvell.com wrote:
> if (priv->global_tx_fc && priv->hw_version != MVPP21) {
> - val = mvpp2_cm3_read(priv, MSS_FC_COM_REG);
> - val |= FLOW_CONTROL_ENABLE_BIT;
> - mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
> + err = mvpp2_enable_global_fc(priv);
> + if (err) {
> + dev_warn(&pdev->dev, "CM3 firmware not running, version should be higher than 18.09\n");
> + dev_warn(&pdev->dev, "Flow control not supported\n");
> + }
I've just booted this on my mcbin-ss, and I get:
mvpp2 f2000000.ethernet: CM3 firmware not running, version should be higher than 18.09
mvpp2 f4000000.ethernet: CM3 firmware not running, version should be higher than 18.09
which is rather odd, because I believe I'm running the 18.12 firmware
from git://github.com/MarvellEmbeddedProcessors/binaries-marvell
branch binaries-marvell-armada-18.12.
Any ideas?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-01-27 14:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 11:43 [PATCH v4 net-next 00/19] net: mvpp2: Add TX Flow Control support stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 01/19] doc: marvell: add cm3-mem device tree bindings description stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 02/19] dts: marvell: add CM3 SRAM memory to cp115 ethernet device tree stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 03/19] net: mvpp2: add CM3 SRAM memory map stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 04/19] doc: marvell: add PPv2.3 description to marvell-pp2.txt stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 05/19] net: mvpp2: add PPv23 version definition stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 06/19] net: mvpp2: always compare hw-version vs MVPP21 stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 07/19] net: mvpp2: increase BM pool size to 2048 buffers stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 08/19] net: mvpp2: increase RXQ size to 1024 descriptors stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 09/19] net: mvpp2: add FCA periodic timer configurations stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 10/19] net: mvpp2: add FCA RXQ non occupied descriptor threshold stefanc
2021-01-27 17:36 ` Willem de Bruijn
2021-01-27 18:41 ` [EXT] " Stefan Chulski
2021-01-28 16:40 ` Russell King - ARM Linux admin
2021-01-27 11:43 ` [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path stefanc
2021-01-27 17:39 ` Willem de Bruijn
2021-01-27 18:27 ` [EXT] " Stefan Chulski
2021-01-27 11:43 ` [PATCH v4 net-next 12/19] net: mvpp2: enable global flow control stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 13/19] net: mvpp2: add RXQ flow control configurations stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 14/19] net: mvpp2: add ethtool flow control configuration support stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 15/19] net: mvpp2: add BM protection underrun feature support stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 16/19] net: mvpp2: add PPv23 RX FIFO flow control stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 17/19] net: mvpp2: set 802.3x GoP Flow Control mode stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 18/19] net: mvpp2: limit minimum ring size to 1024 descriptors stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check stefanc
2021-01-27 14:05 ` Russell King - ARM Linux admin [this message]
2021-01-27 14:37 ` [EXT] " Stefan Chulski
2021-01-27 14:59 ` Russell King - ARM Linux admin
2021-01-27 15:10 ` Stefan Chulski
2021-01-27 15:13 ` Russell King - ARM Linux admin
2021-01-27 15:23 ` Stefan Chulski
2021-01-27 17:55 ` [PATCH v4 net-next 00/19] net: mvpp2: Add TX Flow Control support Willem de Bruijn
2021-01-28 16:43 ` Russell King - ARM Linux admin
2021-01-28 16:47 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127140552.GM1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).