From: Bjorn Helgaas <helgaas@kernel.org>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers
Date: Wed, 27 Jan 2021 09:18:02 -0600 [thread overview]
Message-ID: <20210127151802.GA2985075@bjorn-Precision-5520> (raw)
In-Reply-To: <3228074F-0E0A-4AF1-A950-C978F6FB3908@wdc.com>
On Wed, Jan 27, 2021 at 07:58:26AM +0000, Chaitanya Kulkarni wrote:
> > On Jan 26, 2021, at 11:41 PM, Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com> wrote:
> > On 1/26/21 14:14, Bjorn Helgaas wrote:
> >> From: Bjorn Helgaas <bhelgaas@google.com>
> >>
> >> Use PCI #defines for PCIe Device Control register values instead of
> >> hard-coding bit positions. No functional change intended.
> >>
> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> >
> > I've verified the values present in the include/uapi/linux/pci_regs.h
> > matches open coded bit shift values. LGTM.
> >
> > Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> >
> Something is seriously wrong. I sent out this in the morning and it
> got delivered right now.
I noticed that, too. Seems like the mailing list is really backed up.
Thanks a lot for taking a look at this!
Bjorn
next prev parent reply other threads:[~2021-01-27 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 20:04 [PATCH 0/2] mtip32xx: minor PCI cleanups Bjorn Helgaas
2021-01-26 20:04 ` [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers Bjorn Helgaas
2021-01-26 23:32 ` Chaitanya Kulkarni
2021-01-27 7:58 ` Chaitanya Kulkarni
2021-01-27 15:18 ` Bjorn Helgaas [this message]
2021-01-26 20:04 ` [PATCH 2/2] mtip32xx: prefer pcie_capability_read_word() Bjorn Helgaas
2021-01-26 20:09 ` [PATCH 0/2] mtip32xx: minor PCI cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127151802.GA2985075@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).