From: Al Viro <viro@zeniv.linux.org.uk>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: David Laight <David.Laight@aculab.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iov_iter: optimise iter type checking
Date: Wed, 27 Jan 2021 18:31:52 +0000 [thread overview]
Message-ID: <20210127183152.GP740243@zeniv-ca> (raw)
In-Reply-To: <ed385c4d-99ca-d7aa-8874-96e3c6b743bb@gmail.com>
On Wed, Jan 27, 2021 at 03:48:10PM +0000, Pavel Begunkov wrote:
> On 16/01/2021 05:18, Al Viro wrote:
> > On Sat, Jan 09, 2021 at 10:11:09PM +0000, Pavel Begunkov wrote:
> >
> >>> Does any code actually look at the fields as a pair?
> >>> Would it even be better to use separate bytes?
> >>> Even growing the on-stack structure by a word won't really matter.
> >>
> >> u8 type, rw;
> >>
> >> That won't bloat the struct. I like the idea. If used together compilers
> >> can treat it as u16.
> >
> > Reasonable, and from what I remember from looking through the users,
> > no readers will bother with looking at both at the same time.
>
> Al, are you going turn it into a patch, or prefer me to take over?
I'll massage that a bit and put into #work.iov_iter - just need to dig my
way from under the pile of ->d_revalidate() review...
next prev parent reply other threads:[~2021-01-27 18:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 14:37 [PATCH] iov_iter: optimise iter type checking Pavel Begunkov
2020-12-06 16:01 ` Pavel Begunkov
2021-01-09 16:09 ` Pavel Begunkov
2021-01-09 17:03 ` Al Viro
2021-01-09 21:19 ` Pavel Begunkov
2021-01-09 21:49 ` David Laight
2021-01-09 22:11 ` Pavel Begunkov
2021-01-11 9:35 ` David Laight
2021-01-12 16:04 ` Pavel Begunkov
2021-01-16 5:18 ` Al Viro
2021-01-17 12:12 ` David Laight
2021-01-27 15:48 ` Pavel Begunkov
2021-01-27 16:28 ` David Laight
2021-01-27 18:30 ` Al Viro
2021-01-27 18:31 ` Al Viro [this message]
2021-01-28 11:39 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127183152.GP740243@zeniv-ca \
--to=viro@zeniv.linux.org.uk \
--cc=David.Laight@aculab.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).