linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Lorenzo Carletti <lorenzo.carletti98@gmail.com>
Cc: linus.walleij@linaro.org, andrew@lunn.ch,
	vivien.didelot@gmail.com, f.fainelli@gmail.com,
	davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables
Date: Wed, 27 Jan 2021 21:01:59 +0200	[thread overview]
Message-ID: <20210127190159.s6irvdej3fs4cdai@skbuf> (raw)
In-Reply-To: <20210127010632.23790-2-lorenzo.carletti98@gmail.com>

On Wed, Jan 27, 2021 at 02:06:32AM +0100, Lorenzo Carletti wrote:
> In the rtl8366rb driver there are some jam tables which contain
> undocumented values.
> While trying to understand what these tables actually do,
> I noticed a discrepancy in how one of those was treated.
> Most of them were plain u16 arrays, while the ethernet one was
> an u16 matrix.
> By looking at the vendor's droplets of source code these tables came from,
> I found out that they were all originally u16 matrixes.
> 
> This commit standardizes the jam tables, turning them all into
> jam_tbl_entry arrays. Each entry contains 2 u16 values.
> This change makes it easier to understand how the jam tables are used
> and also makes it possible for a single function to handle all of them,
> removing some duplicated code.
> 
> Signed-off-by: Lorenzo Carletti <lorenzo.carletti98@gmail.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Some trivia to read for next time:
Documentation/process/submitting-patches.rst
Documentation/networking/netdev-FAQ.rst

I'm saying this because you should have used git-format-patch with a
--subject-prefix of "PATCH v2 net-next" so that the tree onto which this
patch is to be applied would be clear. As things stand, the Patchwork
tests added by Jakub have marked your patch as "Target tree name not
specified in the subject":
https://patchwork.kernel.org/project/netdevbpf/patch/20210127010632.23790-2-lorenzo.carletti98@gmail.com/

Also, generally, when people give you a Reviewed-by tag in v1 but you
need to resend v2, you should copy those tags yourself below your
Signed-off-by in the new patch submission. Otherwise, if the patch is
going to be applied, the maintainer will pick up the review tags on the
latest posted version only. When you make significant modifications to
the patch and you're concerned that the reviewers might no longer agree
with the updated version they haven't yet seen, it's ok to drop
Reviewed-by tags. In this case, you dropped Linus's review tag.

  reply	other threads:[~2021-01-27 19:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  1:06 [PATCH V2 0/1] net: dsa: rtl8366rb: change type of jam tables Lorenzo Carletti
2021-01-27  1:06 ` [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init " Lorenzo Carletti
2021-01-27 19:01   ` Vladimir Oltean [this message]
     [not found]     ` <CABRCJOQDLrms1B4TsQonDEUAyXDV22-ufq4eGYZ8wq9KgHVKkA@mail.gmail.com>
2021-01-27 20:17       ` Florian Fainelli
2021-01-27 22:02         ` Lorenzo Carletti
2021-01-27 20:18   ` Florian Fainelli
2021-01-27 21:46   ` Linus Walleij
2021-01-28  4:30 ` [PATCH V2 0/1] net: dsa: rtl8366rb: change type of " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210127190159.s6irvdej3fs4cdai@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.carletti98@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).