linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Hermann.Lauer@uni-heidelberg.de
Cc: linux-arm-kernel@lists.infradead.org, wens@csie.org,
	jernej.skrabec@siol.net, robh+dt@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode
Date: Thu, 28 Jan 2021 15:59:37 +0100	[thread overview]
Message-ID: <20210128145937.vtdi4e2aih7milmt@gilmour> (raw)
In-Reply-To: <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de>

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.de wrote:
> BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
> packet loss rates. The realtek phy driver overrides the settings of the
> pull ups for the delays, so fix this for BananaPro.
>     
> Fix the phy-mode description to correctly reflect this so that the
> implementation doesn't reconfigure the delays incorrectly. This
> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> rx/tx delay config").
> 
> Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board")
> Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>

Applied since it's a fix simple enough, but please provide a changelog
between versions.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2021-01-28 15:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 17:08 [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node Hermann Lauer
2021-01-21 19:54 ` Jernej Škrabec
2021-01-22  3:09   ` Chen-Yu Tsai
2021-01-28  9:40 ` [PATCH v3] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Hermann Lauer
2021-01-28 11:18   ` [PATCH v4] " Hermann.Lauer
2021-01-28 14:59     ` Maxime Ripard [this message]
2021-02-01 12:08       ` Hermann Lauer
2021-02-01 17:29         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128145937.vtdi4e2aih7milmt@gilmour \
    --to=maxime@cerno.tech \
    --cc=Hermann.Lauer@uni-heidelberg.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).