From: Adrien Grassein <adrien.grassein@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
rikard.falkeborn@gmail.com, peter.chen@nxp.com, jun.li@nxp.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Adrien Grassein <adrien.grassein@gmail.com>
Subject: [PATCH 2/2] phy: fsl-imx8mq-usb: handle resettable hubs
Date: Thu, 28 Jan 2021 23:12:55 +0100 [thread overview]
Message-ID: <20210128221255.2673992-2-adrien.grassein@gmail.com> (raw)
In-Reply-To: <20210128221255.2673992-1-adrien.grassein@gmail.com>
Add an optional GPIO in the dtb description that will
be used to reset the connected hub (if any).
Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
---
drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
index a29b4a6f7c24..00abf7814fe9 100644
--- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
+++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
@@ -4,6 +4,7 @@
#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
#include <linux/io.h>
#include <linux/module.h>
#include <linux/of_platform.h>
@@ -36,6 +37,7 @@ struct imx8mq_usb_phy {
struct clk *clk;
void __iomem *base;
struct regulator *vbus;
+ struct gpio_desc *reset_gpio;
};
static int imx8mq_usb_phy_init(struct phy *phy)
@@ -111,6 +113,9 @@ static int imx8mq_phy_power_on(struct phy *phy)
if (ret)
return ret;
+ if (imx_phy->reset_gpio)
+ gpiod_set_value_cansleep(imx_phy->reset_gpio, 0);
+
return clk_prepare_enable(imx_phy->clk);
}
@@ -120,6 +125,8 @@ static int imx8mq_phy_power_off(struct phy *phy)
clk_disable_unprepare(imx_phy->clk);
regulator_disable(imx_phy->vbus);
+ if (imx_phy->reset_gpio)
+ gpiod_set_value_cansleep(imx_phy->reset_gpio, 1);
return 0;
}
@@ -153,6 +160,7 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct imx8mq_usb_phy *imx_phy;
const struct phy_ops *phy_ops;
+ int ret;
imx_phy = devm_kzalloc(dev, sizeof(*imx_phy), GFP_KERNEL);
if (!imx_phy)
@@ -180,6 +188,15 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev)
if (IS_ERR(imx_phy->vbus))
return PTR_ERR(imx_phy->vbus);
+ imx_phy->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
+ if (IS_ERR(imx_phy->reset_gpio)) {
+ ret = PTR_ERR(imx_phy->reset_gpio);
+ if (ret == -ENXIO || ret == -ENODEV)
+ imx_phy->reset_gpio = NULL;
+ else
+ return PTR_ERR(imx_phy->reset_gpio);
+ }
+
phy_set_drvdata(imx_phy->phy, imx_phy);
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
--
2.25.1
next prev parent reply other threads:[~2021-01-28 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 22:12 [PATCH 1/2] dt-bindings: phy-imx8mq-usb: add reset-gpios property Adrien Grassein
2021-01-28 22:12 ` Adrien Grassein [this message]
2021-02-02 2:01 ` [PATCH 2/2] phy: fsl-imx8mq-usb: handle resettable hubs Jun Li
2021-02-09 20:01 ` [PATCH 1/2] dt-bindings: phy-imx8mq-usb: add reset-gpios property Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128221255.2673992-2-adrien.grassein@gmail.com \
--to=adrien.grassein@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=rikard.falkeborn@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).