From: Jakub Kicinski <kuba@kernel.org>
To: Shoaib Rao <rao.shoaib@oracle.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
andy.rudoff@intel.com
Subject: Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG
Date: Fri, 29 Jan 2021 12:02:50 -0800 [thread overview]
Message-ID: <20210129120250.269c366d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <a21dc26a-87dc-18c8-b8bd-24f9797afbad@oracle.com>
On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote:
> >> SO_OOBINLINE does not control the delivery of signal, It controls how
> >> OOB Byte is delivered. It may not be obvious but this change does not
> >> deliver any Byte, just a signal. So, as long as sendmsg flag contains
> >> MSG_OOB, signal will be delivered just like it happens for TCP.
> > Not as far as I can read this code. If MSG_OOB is set the data from the
> > message used to be discarded, and EOPNOTSUPP returned. Now the data gets
> > queued to the socket, and will be read inline.
>
> Data was discarded because the flag was not supported, this patch
> changes that but does not support any urgent data.
When you say it does not support any urgent data do you mean the
message len must be == 0 because something is checking it, or that
the code does not support its handling?
I'm perfectly fine with the former, just point me at the check, please.
> OOB data has some semantics that would have to be followed and if we
> support SO_OOBINLINE we would have to support NOT SO_OOBINLINE.
>
> One can argue that we add a socket option to allow this OR just do what
> TCP does.
next prev parent reply other threads:[~2021-01-29 20:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 15:06 [PATCH] af_unix: Allow Unix sockets to raise SIGURG Matthew Wilcox (Oracle)
2021-01-25 23:36 ` Jakub Kicinski
2021-01-29 17:56 ` Shoaib Rao
2021-01-29 19:06 ` Jakub Kicinski
2021-01-29 19:48 ` Shoaib Rao
2021-01-29 20:02 ` Jakub Kicinski [this message]
2021-01-29 20:10 ` Shoaib Rao
2021-01-29 20:18 ` Jakub Kicinski
2021-01-29 20:44 ` Shoaib Rao
2021-01-29 20:49 ` Shoaib Rao
2021-01-29 21:18 ` Jakub Kicinski
2021-01-29 21:32 ` Matthew Wilcox
2021-01-29 23:47 ` David Laight
2021-01-29 21:54 ` Shoaib Rao
2021-01-29 19:19 ` Matthew Wilcox
2021-01-29 19:54 ` Shoaib Rao
2021-01-29 20:01 ` Shoaib Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129120250.269c366d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andy.rudoff@intel.com \
--cc=davem@davemloft.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rao.shoaib@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).