linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4.9 00/30] 4.9.254-rc1 review
@ 2021-01-29 11:06 Greg Kroah-Hartman
  2021-01-29 11:06 ` [PATCH 4.9 19/30] bpf: Fix buggy rsh min/max bounds tracking Greg Kroah-Hartman
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-01-29 11:06 UTC (permalink / raw)
  To: linux-kernel
  Cc: Greg Kroah-Hartman, torvalds, akpm, linux, shuah, patches,
	lkft-triage, pavel, stable

This is the start of the stable review cycle for the 4.9.254 release.
There are 30 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.254-rc1.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 4.9.254-rc1

Arvind Sankar <nivedita@alum.mit.edu>
    x86/boot/compressed: Disable relocation relaxation

Gaurav Kohli <gkohli@codeaurora.org>
    tracing: Fix race in trace_open and buffer resize call

Wang Hai <wanghai38@huawei.com>
    Revert "mm/slub: fix a memory leak in sysfs_slab_add()"

Dan Carpenter <dan.carpenter@oracle.com>
    net: dsa: b53: fix an off by one in checking "vlan->vid"

Eric Dumazet <edumazet@google.com>
    net_sched: avoid shift-out-of-bounds in tcindex_set_parms()

Matteo Croce <mcroce@microsoft.com>
    ipv6: create multicast route with RTPROT_KERNEL

Alexander Lobakin <alobakin@pm.me>
    skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too

Geert Uytterhoeven <geert+renesas@glider.be>
    sh_eth: Fix power down vs. is_opened flag ordering

Necip Fazil Yildiran <fazilyildiran@gmail.com>
    sh: dma: fix kconfig dependency for G2_DMA

Guillaume Nault <gnault@redhat.com>
    netfilter: rpfilter: mask ecn bits before fib lookup

Will Deacon <will@kernel.org>
    compiler.h: Raise minimum version of GCC to 5.1 for arm64

Daniel Borkmann <daniel@iogearbox.net>
    bpf: Fix buggy rsh min/max bounds tracking

JC Kuo <jckuo@nvidia.com>
    xhci: tegra: Delay for disabling LFPS detector

Mathias Nyman <mathias.nyman@linux.intel.com>
    xhci: make sure TRB is fully written before giving it to the controller

Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
    usb: bdc: Make bdc pci driver depend on BROKEN

Thinh Nguyen <Thinh.Nguyen@synopsys.com>
    usb: udc: core: Use lock when write to soft_connect

Longfang Liu <liulongfang@huawei.com>
    USB: ehci: fix an interrupt calltrace error

Eugene Korenevsky <ekorenevsky@astralinux.ru>
    ehci: fix EHCI host controller initialization sequence

Wang Hui <john.wanghui@huawei.com>
    stm class: Fix module init return on allocation failure

Lars-Peter Clausen <lars@metafoo.de>
    iio: ad5504: Fix setting power-down state

Vincent Mailhol <mailhol.vincent@wanadoo.fr>
    can: dev: can_restart: fix use after free bug

Wolfram Sang <wsa+renesas@sang-engineering.com>
    i2c: octeon: check correct size of maximum RECV_LEN packet

Ben Skeggs <bskeggs@redhat.com>
    drm/nouveau/i2c/gm200: increase width of aux semaphore owner fields

Ben Skeggs <bskeggs@redhat.com>
    drm/nouveau/bios: fix issue shadowing expansion ROMs

Can Guo <cang@codeaurora.org>
    scsi: ufs: Correct the LUN used in eh_device_reset_handler() callback

Cezary Rojewski <cezary.rojewski@intel.com>
    ASoC: Intel: haswell: Add missing pm_ops

Hannes Reinecke <hare@suse.de>
    dm: avoid filesystem lookup in dm_get_dev_t()

Hans de Goede <hdegoede@redhat.com>
    ACPI: scan: Make acpi_bus_get_device() clear return pointer on error

Takashi Iwai <tiwai@suse.de>
    ALSA: hda/via: Add minimum mute flag

Takashi Iwai <tiwai@suse.de>
    ALSA: seq: oss: Fix missing error check in snd_seq_oss_synth_make_info()


-------------

Diffstat:

 Makefile                                           |  4 ++--
 arch/sh/drivers/dma/Kconfig                        |  3 +--
 arch/x86/boot/compressed/Makefile                  |  2 ++
 drivers/acpi/scan.c                                |  2 ++
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c  |  2 +-
 drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c |  8 ++++----
 drivers/hwtracing/stm/heartbeat.c                  |  6 ++++--
 drivers/i2c/busses/i2c-octeon-core.c               |  2 +-
 drivers/iio/dac/ad5504.c                           |  4 ++--
 drivers/md/dm-table.c                              | 15 ++++++++++++---
 drivers/net/can/dev.c                              |  4 ++--
 drivers/net/dsa/b53/b53_common.c                   |  2 +-
 drivers/net/ethernet/renesas/sh_eth.c              |  4 ++--
 drivers/scsi/ufs/ufshcd.c                          | 11 ++++-------
 drivers/usb/gadget/udc/bdc/Kconfig                 |  2 +-
 drivers/usb/gadget/udc/core.c                      | 13 ++++++++++---
 drivers/usb/host/ehci-hcd.c                        | 12 ++++++++++++
 drivers/usb/host/ehci-hub.c                        |  3 +++
 drivers/usb/host/xhci-ring.c                       |  2 ++
 drivers/usb/host/xhci-tegra.c                      |  7 +++++++
 include/linux/compiler-gcc.h                       |  6 ++++++
 kernel/bpf/verifier.c                              |  7 +++----
 kernel/trace/ring_buffer.c                         |  4 ++++
 mm/slub.c                                          |  4 +---
 net/core/skbuff.c                                  |  6 +++++-
 net/ipv4/netfilter/ipt_rpfilter.c                  |  2 +-
 net/ipv6/addrconf.c                                |  1 +
 net/sched/cls_tcindex.c                            |  8 ++++++--
 sound/core/seq/oss/seq_oss_synth.c                 |  3 ++-
 sound/pci/hda/patch_via.c                          |  1 +
 sound/soc/intel/boards/haswell.c                   |  1 +
 31 files changed, 106 insertions(+), 45 deletions(-)



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 4.9 19/30] bpf: Fix buggy rsh min/max bounds tracking
  2021-01-29 11:06 [PATCH 4.9 00/30] 4.9.254-rc1 review Greg Kroah-Hartman
@ 2021-01-29 11:06 ` Greg Kroah-Hartman
  2021-01-29 18:22 ` [PATCH 4.9 00/30] 4.9.254-rc1 review Guenter Roeck
  2021-01-30  7:08 ` Naresh Kamboju
  2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-01-29 11:06 UTC (permalink / raw)
  To: linux-kernel
  Cc: Greg Kroah-Hartman, stable, Daniel Borkmann, John Fastabend, Josef Bacik

From: Daniel Borkmann <daniel@iogearbox.net>

[ no upstream commit ]

Fix incorrect bounds tracking for RSH opcode. Commit f23cc643f9ba ("bpf: fix
range arithmetic for bpf map access") had a wrong assumption about min/max
bounds. The new dst_reg->min_value needs to be derived by right shifting the
max_val bounds, not min_val, and likewise new dst_reg->max_value needs to be
derived by right shifting the min_val bounds, not max_val. Later stable kernels
than 4.9 are not affected since bounds tracking was overall reworked and they
already track this similarly as in the fix.

Fixes: f23cc643f9ba ("bpf: fix range arithmetic for bpf map access")
Reported-by: Ryota Shiga (Flatt Security)
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: John Fastabend <john.fastabend@gmail.com>
Cc: Josef Bacik <jbacik@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 kernel/bpf/verifier.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -1732,12 +1732,11 @@ static void adjust_reg_min_max_vals(stru
 		 * unsigned shift, so make the appropriate casts.
 		 */
 		if (min_val < 0 || dst_reg->min_value < 0)
-			dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
+			reset_reg_range_values(regs, insn->dst_reg);
 		else
-			dst_reg->min_value =
-				(u64)(dst_reg->min_value) >> min_val;
+			dst_reg->min_value = (u64)(dst_reg->min_value) >> max_val;
 		if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
-			dst_reg->max_value >>= max_val;
+			dst_reg->max_value >>= min_val;
 		break;
 	default:
 		reset_reg_range_values(regs, insn->dst_reg);



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4.9 00/30] 4.9.254-rc1 review
  2021-01-29 11:06 [PATCH 4.9 00/30] 4.9.254-rc1 review Greg Kroah-Hartman
  2021-01-29 11:06 ` [PATCH 4.9 19/30] bpf: Fix buggy rsh min/max bounds tracking Greg Kroah-Hartman
@ 2021-01-29 18:22 ` Guenter Roeck
  2021-01-30  7:08 ` Naresh Kamboju
  2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-01-29 18:22 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, torvalds, akpm, shuah, patches, lkft-triage, pavel, stable

On Fri, Jan 29, 2021 at 12:06:36PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.9.254 release.
> There are 30 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000.
> Anything received after that time might be too late.
> 

Build results:
	total: 168 pass: 168 fail: 0
Qemu test results:
	total: 382 pass: 382 fail: 0

Tested-by: Guenter Roeck <linux@roeck-us.net>

Guenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4.9 00/30] 4.9.254-rc1 review
  2021-01-29 11:06 [PATCH 4.9 00/30] 4.9.254-rc1 review Greg Kroah-Hartman
  2021-01-29 11:06 ` [PATCH 4.9 19/30] bpf: Fix buggy rsh min/max bounds tracking Greg Kroah-Hartman
  2021-01-29 18:22 ` [PATCH 4.9 00/30] 4.9.254-rc1 review Guenter Roeck
@ 2021-01-30  7:08 ` Naresh Kamboju
  2 siblings, 0 replies; 4+ messages in thread
From: Naresh Kamboju @ 2021-01-30  7:08 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: open list, Shuah Khan, patches, lkft-triage, linux-stable, pavel,
	Andrew Morton, Linus Torvalds, Guenter Roeck

On Fri, 29 Jan 2021 at 16:42, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 4.9.254 release.
> There are 30 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.254-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>


Summary
------------------------------------------------------------------------

kernel: 4.9.254-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.9.y
git commit: 1aa322729224bcf6471557d67a263fb060158de6
git describe: v4.9.253-31-g1aa322729224
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.9.y/build/v4.9.253-31-g1aa322729224


No regressions (compared to build v4.9.253-28-g02d9a5638c82)


No fixes (compared to build v4.9.253-28-g02d9a5638c82)

Ran 40883 total tests in the following environments and test suites.

Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- i386
- juno-r2 - arm64
- juno-r2-compat
- juno-r2-kasan
- qemu-arm64-clang
- qemu-arm64-kasan
- qemu-x86_64-clang
- qemu-x86_64-kasan
- qemu_arm
- qemu_arm64
- qemu_arm64-compat
- qemu_i386
- qemu_x86_64
- qemu_x86_64-compat
- x15 - arm
- x86_64
- x86-kasan

Test Suites
-----------
* build
* install-android-platform-tools-r2600
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-tracing-tests
* perf
* v4l2-compliance
* ltp-cve-tests
* network-basic-tests
* ltp-open-posix-tests
* kvm-unit-tests

-- 
Linaro LKFT
https://lkft.linaro.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-30  9:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-29 11:06 [PATCH 4.9 00/30] 4.9.254-rc1 review Greg Kroah-Hartman
2021-01-29 11:06 ` [PATCH 4.9 19/30] bpf: Fix buggy rsh min/max bounds tracking Greg Kroah-Hartman
2021-01-29 18:22 ` [PATCH 4.9 00/30] 4.9.254-rc1 review Guenter Roeck
2021-01-30  7:08 ` Naresh Kamboju

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).