Re: [PATCH v2 0/2] Remove the IIO counter ABI

From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: fabrice.gasnier@foss.st.com, fabrice.gasnier@st.com,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	benjamin.gaignard@st.com
Subject: Re: [PATCH v2 0/2] Remove the IIO counter ABI
Date: Sat, 30 Jan 2021 19:04:52 +0000	[thread overview]
Message-ID: <20210130190452.34c6bf37@archlinux> (raw)
In-Reply-To: <cover.1611973018.git.vilhelm.gray@gmail.com>

On Sat, 30 Jan 2021 11:37:02 +0900
William Breathitt Gray <vilhelm.gray@gmail.com> wrote:

> Changes in v2:
>  - Add missing argument to devm_kzalloc() call in quad8_probe().
>  - Remove superfluous 'err' variable from quad8_probe().
> 
> The IIO counter driver has been superseded by the Counter subsystem as
> discussed in [1]. This patchset removes the IIO counter ABI code and
> documentation.
> 
> A patch to remove the IIO counter ABI code from the stm32-lptimer-cnt
> counter driver has been submitted to the list separately [2]; if you
> would like me to combine it with this patchset, please let me know.

No problem, I've already picked that one.

> 
> One final user of the IIO counter ABI code is still remaining for now:
> drivers/iio/trigger/stm32-timer-trigger.c. Is this driver related to the
> drivers/counter/stm32-timer-cnt.c driver? Can it be migrated to the
> Counter subsystem ABI instead?

I'm going to guess that we could probably drop the iio_dev part of the
stm32-timer-trigger entirely, though I'm not totally sure so wouldn't be
confident doing it without someone having hardware to test.  In particular
there may be some connections between whether the device is enabled and
the triggers working that isn't documented anywhere that I can spot.

Whilst that's still in place, I'm going to pick up patch 1 of this set, but
leave patch 2. The ABI is clearly marked deprecated so we shouldn't get
new users and we can pick up that patch hwen the stm32-timer-trigger has
been tidied up as well.

Applied patch 1.  Thanks,

Jonathan

> 
> [1] https://lore.kernel.org/lkml/20210119104105.000010df@Huawei.com/
> [2] https://marc.info/?l=linux-arm-kernel&m=161192667926697
> 
> William Breathitt Gray (2):
>   counter: 104-quad-8: Remove IIO counter ABI
>   iio: Remove the IIO counter ABI documentation
> 
>  Documentation/ABI/testing/sysfs-bus-iio       |  40 --
>  .../testing/sysfs-bus-iio-counter-104-quad-8  | 133 ----
>  MAINTAINERS                                   |   1 -
>  drivers/counter/104-quad-8.c                  | 653 ++----------------
>  drivers/counter/Kconfig                       |   2 +-
>  5 files changed, 65 insertions(+), 764 deletions(-)
>  delete mode 100644 Documentation/ABI/testing/sysfs-bus-iio-counter-104-quad-8
> 