From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4D5C433E0 for ; Sun, 31 Jan 2021 00:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC35464E15 for ; Sun, 31 Jan 2021 00:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232476AbhAaASi (ORCPT ); Sat, 30 Jan 2021 19:18:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232549AbhAaAQ6 (ORCPT ); Sat, 30 Jan 2021 19:16:58 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D10AC061797 for ; Sat, 30 Jan 2021 16:16:22 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id z9so234686pjl.5 for ; Sat, 30 Jan 2021 16:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xvDcVWDMqSlgRKDC/415dsNWXRNDCXGyoKkXgRrWozk=; b=sHfvfBFkHKyTyMjCEaanWGOfbmnW6eqnCByHh+aQy9puH39w/8QOImPSD5ESCNZPPW wQMXyW1xHIQs4H84eMYNrngi6phUfigFjDXPZk8ZZ/IYmOaD44gyo16syDWbj8jV14TC DF//wgzY5SSxBGAAk/rmVD9X/AXccea+NItjjkseOFTfaavrdH+/hKdaZ2+COQFlsVg+ EDMy2LRt91m0sAKAOiUbPfKufcw8qeeH+NxSjaoUhH9jle5bu6E103GzQBmOH5cRg3em x07MiWMxWGuZMomPESLflaGqR5ddIgqF7FNv9cq2OTImt67OHCo+9HJT0SdQiUODHUGa a42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xvDcVWDMqSlgRKDC/415dsNWXRNDCXGyoKkXgRrWozk=; b=qcaVT0xjTjEFU8OF5Saz82wGGWnishuqEtW/A+lhTh3x9LDnbdy/LuwBC6v8guaE5P 8uPR7wr9a2lL2VYoAY+0jmuRD4OaxfDwiC4gFLZ6Q9/IblNh91V9/8GqlYizpel6u7Iv npfYU7HM1yVISfhi08W7a+Xj0eTEzrp5U4I8md0Sx2PeygM6qbKEosPGHD1MVT/dL/pk V1LK7Rm/Ql2KBepZxxM2jAuXboNp6beqVlHbPiWkt8k6lCc+JcMu+jOYrYK2ujktFTW+ yKY+Lhyki3xPd48DcrlxUHjGM9Qr5Zi2hV4mlDkgV5ozWBlH7VQtABEI6iCVRHgPRcc2 Ljng== X-Gm-Message-State: AOAM530T15XP7GK+32ne07wy6L8VyVoa/c+fIkmfRx0HW31+Wvu+bwil BoV+67gxdamniLs/Cp6khNk= X-Google-Smtp-Source: ABdhPJxSJ3S1Hh834JyxNBWkaIPU+kNlBMZlR30PiuMLpD9MM9sZ1et0g2VBjM/ZMxyGVv2eOMlHTg== X-Received: by 2002:a17:90b:30d6:: with SMTP id hi22mr1757058pjb.42.1612052181708; Sat, 30 Jan 2021 16:16:21 -0800 (PST) Received: from sc2-haas01-esx0118.eng.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id e12sm13127365pga.13.2021.01.30.16.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jan 2021 16:16:21 -0800 (PST) From: Nadav Amit X-Google-Original-From: Nadav Amit To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Nadav Amit , Andrea Arcangeli , Andrew Morton , Andy Lutomirski , Dave Hansen , Peter Zijlstra , Thomas Gleixner , Will Deacon , Yu Zhao , Nick Piggin , x86@kernel.org Subject: [RFC 13/20] mm/tlb: introduce tlb_start_ptes() and tlb_end_ptes() Date: Sat, 30 Jan 2021 16:11:25 -0800 Message-Id: <20210131001132.3368247-14-namit@vmware.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210131001132.3368247-1-namit@vmware.com> References: <20210131001132.3368247-1-namit@vmware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nadav Amit Introduce tlb_start_ptes() and tlb_end_ptes() which would be called before and after PTEs are updated and TLB flushes are deferred. This will be later be used for fine granualrity deferred TLB flushing detection. In the meanwhile, move flush_tlb_batched_pending() into tlb_start_ptes(). It was not called from mapping_dirty_helpers by wp_pte() and clean_record_pte(), which might be a bug. No additional functional change is intended. Signed-off-by: Nadav Amit Cc: Andrea Arcangeli Cc: Andrew Morton Cc: Andy Lutomirski Cc: Dave Hansen Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Will Deacon Cc: Yu Zhao Cc: Nick Piggin Cc: x86@kernel.org --- fs/proc/task_mmu.c | 2 ++ include/asm-generic/tlb.h | 18 ++++++++++++++++++ mm/madvise.c | 6 ++++-- mm/mapping_dirty_helpers.c | 15 +++++++++++++-- mm/memory.c | 2 ++ mm/mprotect.c | 3 ++- 6 files changed, 41 insertions(+), 5 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 4cd048ffa0f6..d0cce961fa5c 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1168,6 +1168,7 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr, return 0; pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); + tlb_start_ptes(&cp->tlb); for (; addr != end; pte++, addr += PAGE_SIZE) { ptent = *pte; @@ -1190,6 +1191,7 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr, tlb_flush_pte_range(&cp->tlb, addr, PAGE_SIZE); ClearPageReferenced(page); } + tlb_end_ptes(&cp->tlb); pte_unmap_unlock(pte - 1, ptl); cond_resched(); return 0; diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index 041be2ef4426..10690763090a 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -58,6 +58,11 @@ * Defaults to flushing at tlb_end_vma() to reset the range; helps when * there's large holes between the VMAs. * + * - tlb_start_ptes() / tlb_end_ptes; makr the start / end of PTEs change. + * + * Does internal accounting to allow fine(r) granularity checks for + * pte_accessible() on certain configuration. + * * - tlb_remove_table() * * tlb_remove_table() is the basic primitive to free page-table directories @@ -373,6 +378,10 @@ static inline void tlb_flush(struct mmu_gather *tlb) flush_tlb_range(tlb->vma, tlb->start, tlb->end); } } +#endif + +#if __is_defined(tlb_flush) || \ + IS_ENABLED(CONFIG_ARCH_WANT_AGGRESSIVE_TLB_FLUSH_BATCHING) static inline void tlb_update_vma(struct mmu_gather *tlb, struct vm_area_struct *vma) @@ -523,6 +532,15 @@ static inline void mark_mm_tlb_gen_done(struct mm_struct *mm, u64 gen) #endif /* CONFIG_ARCH_HAS_TLB_GENERATIONS */ +#define tlb_start_ptes(tlb) \ + do { \ + struct mmu_gather *_tlb = (tlb); \ + \ + flush_tlb_batched_pending(_tlb->mm); \ + } while (0) + +static inline void tlb_end_ptes(struct mmu_gather *tlb) { } + /* * tlb_flush_{pte|pmd|pud|p4d}_range() adjust the tlb->start and tlb->end, * and set corresponding cleared_*. diff --git a/mm/madvise.c b/mm/madvise.c index 0938fd3ad228..932c1c2eb9a3 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -392,7 +392,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, #endif tlb_change_page_size(tlb, PAGE_SIZE); orig_pte = pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); - flush_tlb_batched_pending(mm); + tlb_start_ptes(tlb); arch_enter_lazy_mmu_mode(); for (; addr < end; pte++, addr += PAGE_SIZE) { ptent = *pte; @@ -468,6 +468,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, } arch_leave_lazy_mmu_mode(); + tlb_end_ptes(tlb); pte_unmap_unlock(orig_pte, ptl); if (pageout) reclaim_pages(&page_list); @@ -588,7 +589,7 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, tlb_change_page_size(tlb, PAGE_SIZE); orig_pte = pte = pte_offset_map_lock(mm, pmd, addr, &ptl); - flush_tlb_batched_pending(mm); + tlb_start_ptes(tlb); arch_enter_lazy_mmu_mode(); for (; addr != end; pte++, addr += PAGE_SIZE) { ptent = *pte; @@ -692,6 +693,7 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, add_mm_counter(mm, MM_SWAPENTS, nr_swap); } arch_leave_lazy_mmu_mode(); + tlb_end_ptes(tlb); pte_unmap_unlock(orig_pte, ptl); cond_resched(); next: diff --git a/mm/mapping_dirty_helpers.c b/mm/mapping_dirty_helpers.c index 2ce6cf431026..063419ade304 100644 --- a/mm/mapping_dirty_helpers.c +++ b/mm/mapping_dirty_helpers.c @@ -6,6 +6,8 @@ #include #include +#include "internal.h" + /** * struct wp_walk - Private struct for pagetable walk callbacks * @range: Range for mmu notifiers @@ -36,7 +38,10 @@ static int wp_pte(pte_t *pte, unsigned long addr, unsigned long end, pte_t ptent = *pte; if (pte_write(ptent)) { - pte_t old_pte = ptep_modify_prot_start(walk->vma, addr, pte); + pte_t old_pte; + + tlb_start_ptes(&wpwalk->tlb); + old_pte = ptep_modify_prot_start(walk->vma, addr, pte); ptent = pte_wrprotect(old_pte); ptep_modify_prot_commit(walk->vma, addr, pte, old_pte, ptent); @@ -44,6 +49,7 @@ static int wp_pte(pte_t *pte, unsigned long addr, unsigned long end, if (pte_may_need_flush(old_pte, ptent)) tlb_flush_pte_range(&wpwalk->tlb, addr, PAGE_SIZE); + tlb_end_ptes(&wpwalk->tlb); } return 0; @@ -94,13 +100,18 @@ static int clean_record_pte(pte_t *pte, unsigned long addr, if (pte_dirty(ptent)) { pgoff_t pgoff = ((addr - walk->vma->vm_start) >> PAGE_SHIFT) + walk->vma->vm_pgoff - cwalk->bitmap_pgoff; - pte_t old_pte = ptep_modify_prot_start(walk->vma, addr, pte); + pte_t old_pte; + + tlb_start_ptes(&wpwalk->tlb); + + old_pte = ptep_modify_prot_start(walk->vma, addr, pte); ptent = pte_mkclean(old_pte); ptep_modify_prot_commit(walk->vma, addr, pte, old_pte, ptent); wpwalk->total++; tlb_flush_pte_range(&wpwalk->tlb, addr, PAGE_SIZE); + tlb_end_ptes(&wpwalk->tlb); __set_bit(pgoff, cwalk->bitmap); cwalk->start = min(cwalk->start, pgoff); diff --git a/mm/memory.c b/mm/memory.c index 9e8576a83147..929a93c50d9a 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1221,6 +1221,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, init_rss_vec(rss); start_pte = pte_offset_map_lock(mm, pmd, addr, &ptl); pte = start_pte; + tlb_start_ptes(tlb); flush_tlb_batched_pending(mm); arch_enter_lazy_mmu_mode(); do { @@ -1314,6 +1315,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, add_mm_rss_vec(mm, rss); arch_leave_lazy_mmu_mode(); + tlb_end_ptes(tlb); /* Do the actual TLB flush before dropping ptl */ if (force_flush) tlb_flush_mmu_tlbonly(tlb); diff --git a/mm/mprotect.c b/mm/mprotect.c index b7473d2c9a1f..1258bbe42ee1 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -70,7 +70,7 @@ static unsigned long change_pte_range(struct mmu_gather *tlb, atomic_read(&vma->vm_mm->mm_users) == 1) target_node = numa_node_id(); - flush_tlb_batched_pending(vma->vm_mm); + tlb_start_ptes(tlb); arch_enter_lazy_mmu_mode(); do { oldpte = *pte; @@ -182,6 +182,7 @@ static unsigned long change_pte_range(struct mmu_gather *tlb, } } while (pte++, addr += PAGE_SIZE, addr != end); arch_leave_lazy_mmu_mode(); + tlb_end_ptes(tlb); pte_unmap_unlock(pte - 1, ptl); return pages; -- 2.25.1