From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE01C433E0 for ; Mon, 1 Feb 2021 20:49:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 965F364ECE for ; Mon, 1 Feb 2021 20:49:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231732AbhBAUtf (ORCPT ); Mon, 1 Feb 2021 15:49:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56123 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbhBAUtc (ORCPT ); Mon, 1 Feb 2021 15:49:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612212486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dx+a2s/jKD+bm6v2qBtcJrio8FJGKN2zZWR18xESCUE=; b=b4DrEK7TIJCFrG2m/R85vxXAiX4EWmDVfvIqu/DnQCX48IWIss2cnjrHEmytkBBjX/y/ba WJNeIG7g4YyVutdPKiV7mgSleJX6DGg0KNBF1cKTOn0k/YvUdahTQ4n7V2TiD31Z/RyJSC gs2kL5Acb5zVjpHrD115/etUi9JPti4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-8dV7A_cmM-igASv8WzLAfg-1; Mon, 01 Feb 2021 15:48:02 -0500 X-MC-Unique: 8dV7A_cmM-igASv8WzLAfg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89FEC10054FF; Mon, 1 Feb 2021 20:47:59 +0000 (UTC) Received: from omen.home.shazbot.org (ovpn-112-255.phx2.redhat.com [10.3.112.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D80260877; Mon, 1 Feb 2021 20:47:58 +0000 (UTC) Date: Mon, 1 Feb 2021 13:47:57 -0700 From: Alex Williamson To: Matthew Rosato Cc: Cornelia Huck , Max Gurtovoy , jgg@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, liranl@nvidia.com, oren@nvidia.com, tzahio@nvidia.com, leonro@nvidia.com, yarong@nvidia.com, aviadye@nvidia.com, shahafs@nvidia.com, artemp@nvidia.com, kwankhede@nvidia.com, ACurrid@nvidia.com, gmataev@nvidia.com, cjia@nvidia.com, yishaih@nvidia.com, aik@ozlabs.ru Subject: Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue Message-ID: <20210201134757.375c91bf@omen.home.shazbot.org> In-Reply-To: <139adb14-f75a-25ef-06da-e87729c2ccf2@linux.ibm.com> References: <20210201162828.5938-1-mgurtovoy@nvidia.com> <20210201162828.5938-7-mgurtovoy@nvidia.com> <20210201175214.0dc3ba14.cohuck@redhat.com> <139adb14-f75a-25ef-06da-e87729c2ccf2@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Feb 2021 12:08:45 -0500 Matthew Rosato wrote: > On 2/1/21 11:52 AM, Cornelia Huck wrote: > > On Mon, 1 Feb 2021 16:28:25 +0000 > > Max Gurtovoy wrote: > > > >> In case allocation fails, we must behave correctly and exit with error. > >> > >> Signed-off-by: Max Gurtovoy > > > > Fixes: e6b817d4b821 ("vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO") > > > > Reviewed-by: Cornelia Huck > > > > I think this should go in independently of this series. > > > Agreed, makes sense to me -- thanks for finding. > > Reviewed-by: Matthew Rosato I can grab this one, and 5/9. Connie do you want to toss an R-b at 5/9? Thanks, Alex