From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5905FC433E0 for ; Mon, 1 Feb 2021 17:19:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F02FE64E54 for ; Mon, 1 Feb 2021 17:19:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232118AbhBARTP (ORCPT ); Mon, 1 Feb 2021 12:19:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbhBARTH (ORCPT ); Mon, 1 Feb 2021 12:19:07 -0500 Received: from srv1.deutnet.info (srv1.deutnet.info [IPv6:2a01:4f8:c2c:6846::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8382AC06174A; Mon, 1 Feb 2021 09:18:27 -0800 (PST) Received: from [2a01:cb14:a98:4900:be5f:f4ff:fe8b:2fc1] (helo=sonata) by srv1.deutnet.info with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6cqA-0005fW-TW; Mon, 01 Feb 2021 18:18:18 +0100 Received: from agriveaux by sonata with local (Exim 4.92) (envelope-from ) id 1l6cqA-0002FD-JO; Mon, 01 Feb 2021 18:18:18 +0100 Date: Mon, 1 Feb 2021 18:18:18 +0100 From: agriveaux To: Maxime Ripard , robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, agriveaux@deutnet.info Subject: Re: [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2 Message-ID: <20210201171236.GA7024@localhost.localdomain> References: <20210124193903.21401-1-agriveaux@deutnet.info> <20210128172329.ncuda3xlgpmefpqk@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210128172329.ncuda3xlgpmefpqk@gilmour> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 06:23:29PM +0100, Maxime Ripard wrote: > Hi, Hi, > > On Sun, Jan 24, 2021 at 08:39:03PM +0100, Alexandre GRIVEAUX wrote: > > Add Inet 86V Rev 2 support, based upon Inet 86VS. > > > > The Inet 86V use SL1536 touchpanel controller, the Inet 86VS a GSL1680, > > which make them both incompatible. > > > > Missing things: > > - Accelerometer (MXC6225X) > > - Touchpanel (Sitronix SL1536) > > - Nand (29F32G08CBACA) > > - Camera (HCWY0308) > > > > Signed-off-by: Alexandre GRIVEAUX > > --- > > arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts | 17 +++++++++++++++++ > > You have to add it to the Makefile > Ok. > > 1 file changed, 17 insertions(+) > > create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts > > > > diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts > > new file mode 100644 > > index 000000000000..581083e932d8 > > --- /dev/null > > +++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts > > @@ -0,0 +1,17 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright 2021 Alexandre Griveaux > > + * > > + * Minimal dts file for the iNet 86V > > + */ > > + > > +/dts-v1/; > > + > > +#include "sun5i-a13.dtsi" > > +#include "sun5i-reference-design-tablet.dtsi" > > + > > +/ { > > + model = "iNET 86V Rev 02"; > > + compatible = "inet,86v-rev2", "allwinner,sun5i-a13"; > > inet should be documented in the vendor prefixes, and that compatible > should be documented in Documentation/devicetree/bindings/arm/sunxi.yaml > I forgot, but should be: - description: iNet-86V Rev 02 items: - const: primux,inet86v-rev2 - const: allwinner,sun5i-a13 > Having the first rev compatible would be good too Unfortunatly, I didn't find inet86v rev1 on FCC website and on linux-sunxi. > > > + > > +}; > > But I'm wondering. If there's nothing here to add, why would we need > that DT in the first place? > I prefer to add often instead of bulk adding, and to show there are some board to add missing things like those above. > Maxime Thanks, Alexandre.