From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] opp: Don't ignore clk_get() errors other than -ENOENT
Date: Tue, 2 Feb 2021 10:05:06 +0530 [thread overview]
Message-ID: <20210202043506.kkw6ha4r7dp6wknc@vireshk-i7> (raw)
In-Reply-To: <e6523427-0484-18c3-5b66-a35146556bab@gmail.com>
On 01-02-21, 22:54, Dmitry Osipenko wrote:
> Thanks, looks okay.
>
> Although, I think the previous variant of coding style was a bit more appropriate, i.e. like this:
>
> dev_err_probe(dev, "%s: Couldn't find clock: %d\n", __func__, ret);
>
> return ERR_PTR(ret);
Okay will move to that.
--
viresh
next prev parent reply other threads:[~2021-02-02 4:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 4:22 [PATCH V2] opp: Don't ignore clk_get() errors other than -ENOENT Viresh Kumar
2021-02-01 19:54 ` Dmitry Osipenko
2021-02-02 4:35 ` Viresh Kumar [this message]
2021-02-11 19:19 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202043506.kkw6ha4r7dp6wknc@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=digetx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).