linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Minchan Kim <minchan@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	"(Exiting) Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	Liam Mark <lmark@codeaurora.org>,
	labbott@redhat.com, Brian Starkey <Brian.Starkey@arm.com>,
	John Stultz <john.stultz@linaro.org>,
	Christian K??nig <christian.koenig@amd.com>,
	Chris Goldsworthy <cgoldswo@codeaurora.org>,
	??rjan Eide <orjan.eide@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	James Jones <jajones@nvidia.com>,
	Hridya Valsaraju <hridya@google.com>,
	Sandeep Patil <sspatil@google.com>,
	linux-media <linux-media@vger.kernel.org>,
	DRI mailing list <dri-devel@lists.freedesktop.org>,
	"moderated list:DMA BUFFER SHARING FRAMEWORK" 
	<linaro-mm-sig@lists.linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-team <kernel-team@android.com>
Subject: Re: [PATCH 1/1] dma-buf: heaps: Map system heap pages as managed by linux vm
Date: Tue, 2 Feb 2021 07:03:36 +0000	[thread overview]
Message-ID: <20210202070336.GA3535861@infradead.org> (raw)
In-Reply-To: <CAJuCfpH5nwvtMR+32G0-xa_hY-b_Hnw=Figqq9xcsTGgJhOiww@mail.gmail.com>

IMHO the

	BUG_ON(vma->vm_flags & VM_PFNMAP);

in vm_insert_page should just become a WARN_ON_ONCE with an error
return, and then we just need to gradually fix up the callers that
trigger it instead of coming up with workarounds like this.

  reply	other threads:[~2021-02-02  7:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28  8:38 [PATCH 1/1] dma-buf: heaps: Map system heap pages as managed by linux vm Suren Baghdasaryan
2021-01-28  8:41 ` Suren Baghdasaryan
2021-01-28  9:13 ` Christoph Hellwig
2021-01-28 17:52   ` Suren Baghdasaryan
2021-01-28 18:19     ` Minchan Kim
     [not found]       ` <CAJuCfpF78RYedBoAgkDdgMdfSmNwC2AQk-zZxAqkhCdtBB9gtQ@mail.gmail.com>
2021-02-02  1:08         ` Suren Baghdasaryan
2021-02-02  7:03           ` Christoph Hellwig [this message]
2021-02-02  8:44             ` Suren Baghdasaryan
2021-02-02  8:51               ` Christoph Hellwig
2021-02-02 18:23                 ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202070336.GA3535861@infradead.org \
    --to=hch@infradead.org \
    --cc=Brian.Starkey@arm.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=cgoldswo@codeaurora.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hridya@google.com \
    --cc=jajones@nvidia.com \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=labbott@redhat.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lmark@codeaurora.org \
    --cc=minchan@kernel.org \
    --cc=orjan.eide@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=sspatil@google.com \
    --cc=sumit.semwal@linaro.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).