From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Yue Hu <zbestahu@gmail.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, linux-kernel@vger.kernel.org,
huyue2@yulong.com, zbestahu@163.com
Subject: Re: [PATCH] sched/topology: Switch to sched_debug() for conditional sched domain printk
Date: Wed, 3 Feb 2021 16:29:55 +0530 [thread overview]
Message-ID: <20210203105955.GF1239129@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210203181019.00007024.zbestahu@gmail.com>
* Yue Hu <zbestahu@gmail.com> [2021-02-03 18:10:19]:
> On Wed, 3 Feb 2021 15:22:56 +0530
> Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote:
>
> > * Yue Hu <zbestahu@gmail.com> [2021-02-03 12:20:10]:
> >
> >
> > sched_debug() would only be present in CONFIG_SCHED_DEBUG. Right?
> > In which case there would be a build failure with your change in
> > !CONFIG_SCHED_DEBUG config.
> >
> > or Am I missing something?
>
> sched_debug() is also defined for !CONFIG_SCHED_DEBUG as below:
>
> static inline bool sched_debug(void)
> {
> return false;
> }
>
ah .. right .. somehow I missed this.
--
Thanks and Regards
Srikar Dronamraju
prev parent reply other threads:[~2021-02-03 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 4:20 [PATCH] sched/topology: Switch to sched_debug() for conditional sched domain printk Yue Hu
2021-02-03 9:52 ` Srikar Dronamraju
2021-02-03 10:10 ` Yue Hu
2021-02-03 10:59 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203105955.GF1239129@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=huyue2@yulong.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=zbestahu@163.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).