From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E95AC4332D for ; Wed, 3 Feb 2021 11:23:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEEAD64F61 for ; Wed, 3 Feb 2021 11:23:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234236AbhBCLXc (ORCPT ); Wed, 3 Feb 2021 06:23:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:34424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234198AbhBCLXI (ORCPT ); Wed, 3 Feb 2021 06:23:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B73E164DE8; Wed, 3 Feb 2021 11:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612351346; bh=wGQw7gT3qnKCIXEO+rxqRvVbPbNtV92xRV2Pv+Ej3+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MrJAtf5mnK1C4Q4ZyKjla2kAdXf633/lnbrk7VmF4rTw8ELv9cY7AI3lYFHz5IvTs gW1JO8UMu0KWxpiE11pDElcoFi2aScKR/6EtEhTveStAUFXYmhZ/2VkMZcgd1/0YfE ni15CbrfkH0uB9TmCzEv5FfL+g5ymnw5CEbyZXJD4ppEFij+lOdgpYmtLPj5YnxQt2 S89UXBGzveoZJe7weH0eyO7487Q9x29lPyzQEfs7eq9AcnO8mCcpuFXjNyVKHYr8yx p+BAk8A9gP2L8aa7Eyu5laiQUOjkYC5JRKTNmmv8FsKcsF1NgygkcixHo6F7gFSZQG dH3CVM+A3lgnQ== Date: Wed, 3 Feb 2021 16:52:22 +0530 From: Vinod Koul To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Herbert Xu , "David S. Miller" , Daniel Palmer , Bartosz Golaszewski , Avi Fishman , Tomer Maimon , Tali Perry , Joerg Roedel , Will Deacon , Andrew Jeffery , Joel Stanley , Wim Van Sebroeck , Guenter Roeck , Yoshihiro Shimoda , Vincent Cheng , linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, iommu@lists.linux-foundation.org, linux-watchdog@vger.kernel.org, Eric Anholt , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , Pavel Machek , Ulf Hansson , Kishon Vijay Abraham I , Geert Uytterhoeven , Daniel Lezcano , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas Message-ID: <20210203112222.GO2771@vkoul-mobl> References: <20210202205544.24812-1-robh@kernel.org> <20210202205544.24812-3-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202205544.24812-3-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-02-21, 14:55, Rob Herring wrote: > Properties in if/then schemas weren't getting checked by the meta-schemas. > Enabling meta-schema checks finds several errors. > > The use of an 'items' schema (as opposed to the list form) is wrong in > some cases as it applies to all entries. 'contains' is the correct schema > to use in the case of multiple entries. > > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Eric Anholt > Cc: Nicolas Saenz Julienne > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: Pavel Machek > Cc: Ulf Hansson > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Daniel Lezcano > Cc: linux-crypto@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-leds@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 3 +-- > .../devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 2 +- > Documentation/devicetree/bindings/leds/ti,tca6507.yaml | 1 + > Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 +- > Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +-- > .../devicetree/bindings/phy/renesas,usb2-phy.yaml | 5 ++--- For phy: Acked-By: Vinod Koul -- ~Vinod