[PATCH] kernel: debug: fix typo issue

[PATCH] kernel: debug: fix typo issue

[samirweng1979]

From: wengjianfeng <wengjianfeng@yulong.com>

change 'regster' to 'register'.

Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
---
 kernel/debug/gdbstub.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
index a77df59..e149a0a 100644
--- a/kernel/debug/gdbstub.c
+++ b/kernel/debug/gdbstub.c
@@ -595,7 +595,7 @@ static char *gdb_hex_reg_helper(int regnum, char *out)
 			    dbg_reg_def[i].size);
 }
 
-/* Handle the 'p' individual regster get */
+/* Handle the 'p' individual register get */
 static void gdb_cmd_reg_get(struct kgdb_state *ks)
 {
 	unsigned long regnum;
@@ -610,7 +610,7 @@ static void gdb_cmd_reg_get(struct kgdb_state *ks)
 	gdb_hex_reg_helper(regnum, remcom_out_buffer);
 }
 
-/* Handle the 'P' individual regster set */
+/* Handle the 'P' individual register set */
 static void gdb_cmd_reg_set(struct kgdb_state *ks)
 {
 	unsigned long regnum;
-- 
1.9.1

Re: [PATCH] kernel: debug: fix typo issue

[Daniel Thompson]

On Wed, Feb 03, 2021 at 04:10:34PM +0800, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
> 
> change 'regster' to 'register'.
> 
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>

It looks like the Subject line might not be correct for this patch?

Is it really the first time this patch has been circulated or should it
have been tagged RESEND or v2?


Daniel.


> ---
>  kernel/debug/gdbstub.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
> index a77df59..e149a0a 100644
> --- a/kernel/debug/gdbstub.c
> +++ b/kernel/debug/gdbstub.c
> @@ -595,7 +595,7 @@ static char *gdb_hex_reg_helper(int regnum, char *out)
>  			    dbg_reg_def[i].size);
>  }
>  
> -/* Handle the 'p' individual regster get */
> +/* Handle the 'p' individual register get */
>  static void gdb_cmd_reg_get(struct kgdb_state *ks)
>  {
>  	unsigned long regnum;
> @@ -610,7 +610,7 @@ static void gdb_cmd_reg_get(struct kgdb_state *ks)
>  	gdb_hex_reg_helper(regnum, remcom_out_buffer);
>  }
>  
> -/* Handle the 'P' individual regster set */
> +/* Handle the 'P' individual register set */
>  static void gdb_cmd_reg_set(struct kgdb_state *ks)
>  {
>  	unsigned long regnum;
> -- 
> 1.9.1
> 
> 

Re: [PATCH] kernel: debug: fix typo issue

[wengjianfeng]

On Wed, 3 Feb 2021 11:23:59 +0000
Daniel Thompson <daniel.thompson@linaro.org> wrote:

> On Wed, Feb 03, 2021 at 04:10:34PM +0800, samirweng1979 wrote:
> > From: wengjianfeng <wengjianfeng@yulong.com>
> > 
> > change 'regster' to 'register'.
> > 
> > Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> 
> It looks like the Subject line might not be correct for this patch?
> 
> Is it really the first time this patch has been circulated or should
> it have been tagged RESEND or v2?
> 
> 
> Daniel.
> 
> 
> > ---
> >  kernel/debug/gdbstub.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
> > index a77df59..e149a0a 100644
> > --- a/kernel/debug/gdbstub.c
> > +++ b/kernel/debug/gdbstub.c
> > @@ -595,7 +595,7 @@ static char *gdb_hex_reg_helper(int regnum,
> > char *out) dbg_reg_def[i].size);
> >  }
> >  
> > -/* Handle the 'p' individual regster get */
> > +/* Handle the 'p' individual register get */
> >  static void gdb_cmd_reg_get(struct kgdb_state *ks)
> >  {
> >  	unsigned long regnum;
> > @@ -610,7 +610,7 @@ static void gdb_cmd_reg_get(struct kgdb_state
> > *ks) gdb_hex_reg_helper(regnum, remcom_out_buffer);
> >  }
> >  
> > -/* Handle the 'P' individual regster set */
> > +/* Handle the 'P' individual register set */
> >  static void gdb_cmd_reg_set(struct kgdb_state *ks)
> >  {
> >  	unsigned long regnum;
> > -- 
> > 1.9.1
> > 
> > 


Hi Daniel,
   The patch was first sent on January 25, but nobody relply me, so I
   just resend the patch, and the patch is the same as last time,does I
   need add RESEND tag? thanks.

Re: [PATCH] kernel: debug: fix typo issue

[Daniel Thompson]

On Wed, Feb 03, 2021 at 07:36:09PM +0800, wengjianfeng wrote:
> On Wed, 3 Feb 2021 11:23:59 +0000
> Daniel Thompson <daniel.thompson@linaro.org> wrote:
> 
> > On Wed, Feb 03, 2021 at 04:10:34PM +0800, samirweng1979 wrote:
> > > From: wengjianfeng <wengjianfeng@yulong.com>
> > > 
> > > change 'regster' to 'register'.
> > > 
> > > Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> > 
> > It looks like the Subject line might not be correct for this patch?
> > 
> > Is it really the first time this patch has been circulated or should
> > it have been tagged RESEND or v2?
>
>    The patch was first sent on January 25, but nobody relply me, so I
>    just resend the patch, and the patch is the same as last time,does I
>    need add RESEND tag? thanks.
 
Yes. When resending a patch adding a RESEND is a useful courtesy to let
the maintainer know why they have received two copies of the same patch
(and to make clear that the content is the same).


Daniel.

Re: [PATCH] kernel: debug: fix typo issue

[Daniel Thompson]

On Wed, Feb 03, 2021 at 04:10:34PM +0800, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
> 
> change 'regster' to 'register'.
> 
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>

Applied. Thanks.