From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21765C433DB for ; Wed, 3 Feb 2021 17:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF72464F6A for ; Wed, 3 Feb 2021 17:25:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbhBCRZP (ORCPT ); Wed, 3 Feb 2021 12:25:15 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:56186 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbhBCRYC (ORCPT ); Wed, 3 Feb 2021 12:24:02 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 542691C0B9C; Wed, 3 Feb 2021 18:23:02 +0100 (CET) Date: Wed, 3 Feb 2021 18:23:02 +0100 From: Pavel Machek To: Marek Behun Cc: Sven Schuchmann , Dan Murphy , Rob Herring , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1] leds: lp50xx: add setting of default intensity from DT Message-ID: <20210203172302.GB23019@duo.ucw.cz> References: <20210119105312.2636-1-schuchmann@schleissheimer.de> <20210203142940.GB12369@duo.ucw.cz> <20210203163555.GA23019@duo.ucw.cz> <20210203182137.339f8470@nic.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PmA2V3Z32TCmWXqI" Content-Disposition: inline In-Reply-To: <20210203182137.339f8470@nic.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > If I would not have the default-intensity I would actually see nothin= g, > > > since the intensity (which goes from 0-255) of each led is initialize= d with 0. > > >=20 > > > I hope I could clarify this a little more? =20 > >=20 > > Yes, sounds reasonable. Could we get default intensity of 100% on all > > channels if nothing else is specified? > >=20 > > Or maybe simply "if intensity is not specified, start with 100%, and > > use explicit =3D0 if other color is expected". > >=20 > > Best regards, > > Pavel >=20 > Is the property default-intensity documented in DT bindings? >=20 > Wouldn't it be better if the property was used in the multi-led node > instead of the channel node? I.e. > multi-led@3 { > color =3D ; > default-intensity =3D <100 0 0>; > }; Yes, this would be better. --=20 http://www.livejournal.com/~pavelmachek --PmA2V3Z32TCmWXqI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYBrb9gAKCRAw5/Bqldv6 8lwEAJ97DLDrkxgNNI43oTtWvfSARyO+lACgtaQJ/qjQH5PZCE9JZY03DGw5O/0= =2YLF -----END PGP SIGNATURE----- --PmA2V3Z32TCmWXqI--