From: Jakub Kicinski <kuba@kernel.org>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"willemdebruijn.kernel@gmail.com"
<willemdebruijn.kernel@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
"Geethasowjanya Akula" <gakula@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration
Date: Thu, 4 Feb 2021 10:50:36 -0800 [thread overview]
Message-ID: <20210204105036.0e6cd8a9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <MWHPR18MB142117DBE8659D68794E18D3DEB39@MWHPR18MB1421.namprd18.prod.outlook.com>
On Thu, 4 Feb 2021 17:37:41 +0000 Hariprasad Kelam wrote:
> > > + req->args.speed = req_ks.base.speed;
> > > + /* firmware expects 1 for half duplex and 0 for full duplex
> > > + * hence inverting
> > > + */
> > > + req->args.duplex = req_ks.base.duplex ^ 0x1;
> > > + req->args.an = req_ks.base.autoneg;
> > > + otx2_get_advertised_mode(&req_ks, &req->args.mode);
> >
> > But that only returns the first bit set. What does the device actually do? What
> > if the user cleared a middle bit?
> >
> This is initial patch series to support advertised modes. Current firmware design is such that
> It can handle only one advertised mode. Due to this limitation we are always checking
> The first set bit in advertised modes and passing it to firmware.
> Will add multi advertised mode support in near future.
Looking at patch 6 it seems like the get side already supports multiple
modes, although the example output only lists supported no advertised.
Is the device actually doing IEEE autoneg or just configures the speed,
lanes etc. according to the link mode selected?
next prev parent reply other threads:[~2021-02-04 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 17:37 [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration Hariprasad Kelam
2021-02-04 18:50 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-07 15:22 Hariprasad Kelam
2021-02-05 14:15 Hariprasad Kelam
2021-02-05 19:25 ` Jakub Kicinski
[not found] <1612098665-187767-1-git-send-email-hkelam@marvell.com>
[not found] ` <1612098665-187767-8-git-send-email-hkelam@marvell.com>
2021-02-03 1:29 ` Jakub Kicinski
2021-02-01 5:24 [Patch v3 net-next 0/7] ethtool support for fec and " Hariprasad Kelam
2021-02-01 5:24 ` [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical " Hariprasad Kelam
2021-02-03 0:48 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204105036.0e6cd8a9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).