From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3024EC433E6 for ; Thu, 4 Feb 2021 19:58:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0F6664F6D for ; Thu, 4 Feb 2021 19:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239894AbhBDT6t (ORCPT ); Thu, 4 Feb 2021 14:58:49 -0500 Received: from mga04.intel.com ([192.55.52.120]:64649 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239524AbhBDTxD (ORCPT ); Thu, 4 Feb 2021 14:53:03 -0500 IronPort-SDR: xhiiU7J+LIIjyYXnAcV9002zpXaQ0xrGz7DoMSL1awV70dg5EVcC2OCzDhkj/ZjPgymdqnoAG4 KI1OTR5oLJ+g== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="178755296" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="178755296" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 11:52:21 -0800 IronPort-SDR: lk2OeIHmNPWbmvRojJjqR8Xtfh20RG7xmOB4Z1oM64zOBayunz7AhdCrNPMsooc6EW9bI/cxGe DT69vT3vA40Q== X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="434088875" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.188.246]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 11:52:20 -0800 Date: Thu, 4 Feb 2021 11:52:20 -0800 From: Jesse Brandeburg To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , John Hubbard , David Rientjes , Yisen Zhuang , Salil Mehta , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions Message-ID: <20210204115220.0000018d@intel.com> In-Reply-To: <20210202133030.5760-5-alobakin@pm.me> References: <20210202133030.5760-1-alobakin@pm.me> <20210202133030.5760-5-alobakin@pm.me> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexander Lobakin wrote: > Now we can remove a bunch of identical functions from the drivers and > make them use common dev_page_is_reusable(). All {,un}likely() checks > are omitted since it's already present in this helper. > Also update some comments near the call sites. > > Suggested-by: David Rientjes > Suggested-by: Jakub Kicinski > Cc: John Hubbard > Signed-off-by: Alexander Lobakin I don't know why it was missed in the series update, but: Reviewed-by: Jesse Brandeburg