From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Xulin Sun <xulin.sun@windriver.com>
Cc: wg@grandegger.com, dmurphy@ti.com, sriram.dash@samsung.com,
kuba@kernel.org, davem@davemloft.net, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xulinsun@gmail.com
Subject: Re: [PATCH 2/2] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment
Date: Fri, 5 Feb 2021 09:52:15 +0100 [thread overview]
Message-ID: <20210205085215.sgsvtys5z4gm3ict@hardanger.blackshift.org> (raw)
In-Reply-To: <9cae961a-881d-8678-6ec3-0fd00c74c8ad@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]
On 05.02.2021 16:46:16, Xulin Sun wrote:
> On 2021/2/5 下午4:19, Marc Kleine-Budde wrote:
> > On 05.02.2021 15:25:59, Xulin Sun wrote:
> > > If the previous can_net device has been successfully allocated, its
> > > private data structure is impossible to be empty, remove this redundant
> > > error return judgment. Otherwise, memory leaks for alloc_candev() will
> > > be triggered.
> > Your analysis is correct, the netdev_priv() will never fail. But how
> > will this trigger a mem leak on alloc_candev()? I've removed that
>
> The previous code judges the netdev_priv is empty, and then goto out. The
> correct approach should add free_candev(net_dev) before goto.
>
> The code Like:
>
> class_dev = netdev_priv(net_dev);
> if (!class_dev) {
> dev_err(dev, "Failed to init netdev cdevate");
> + free_candev(net_dev);
> goto out;
> }
>
> Otherwise, memory leaks for alloc_candev() will be triggered.
No - as you said in the original patch description. The return value
of netdev_priv() cannot be NULL, as net_dev is not NULL.
> Now directly remove the impossible error return judgment to resolve
> the above possible issue.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-05 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 7:25 [PATCH 1/2] can: m_can: m_can_plat_probe(): free can_net device in case probe fails Xulin Sun
2021-02-05 7:25 ` [PATCH 2/2] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment Xulin Sun
2021-02-05 8:19 ` Marc Kleine-Budde
2021-02-05 8:46 ` Xulin Sun
2021-02-05 8:52 ` Marc Kleine-Budde [this message]
2021-02-05 8:05 ` [PATCH 1/2] can: m_can: m_can_plat_probe(): free can_net device in case probe fails Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205085215.sgsvtys5z4gm3ict@hardanger.blackshift.org \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
--cc=xulin.sun@windriver.com \
--cc=xulinsun@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).