From: Viresh Kumar <viresh.kumar@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Vincent Guittot <vincent.guittot@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
anmar.oueja@linaro.org, Bill Mills <bill.mills@linaro.org>,
David Gibson <david@gibson.dropbear.id.au>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH V7 4/6] kbuild: Add support to build overlays (%.dtbo)
Date: Fri, 5 Feb 2021 15:25:45 +0530 [thread overview]
Message-ID: <20210205095545.woevnkxg3ar7ctys@vireshk-i7> (raw)
In-Reply-To: <CAMuHMdWUMcMcJxnC+oML8P0+r72_+d6RWGY50dOWCUECdJGWPA@mail.gmail.com>
On 05-02-21, 10:41, Geert Uytterhoeven wrote:
> Hi Viresh,
>
> On Fri, Feb 5, 2021 at 10:25 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 05-02-21, 10:02, Geert Uytterhoeven wrote:
> > > Thanks for your patch
> > > (which I only noticed because it appeared in dt-rh/for-next ;-)
> > >
> > > On Fri, Jan 29, 2021 at 8:31 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > > > Add support for building DT overlays (%.dtbo). The overlay's source file
> > > > will have the usual extension, i.e. .dts, though the blob will have
> > >
> > > Why use .dts and not .dtso for overlays?
> > > Because you originally (until v5) had a single rule for building .dtb
> > > and .dtbo files?
> >
> > I am fine with doing that as well if Rob and David agree to it. Rob
> > did suggest that at one point but we didn't do much about it later on
> > for some reason.
> >
> > FWIW, this will also require a change in the DTC compiler.
>
> Care to explain why? I've been using .dtsi for ages in
> https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/renesas-overlays
I don't see you building them anywhere, they aren't added to the
Makefile ever. What am I missing ?
actually none of the dtso's were added to any makefile in that branch.
Anyway, the DTC needs to know how to treat the dtso format and it will
error out currently with unknown format kind of errors.
Below email [1] have some information on the kind of changes required
here. Also note that we had to do similar changes for dtbo earlier
[2].
--
viresh
[1] https://lore.kernel.org/lkml/CAK7LNASViCOTGR7yDTfh0O+PAu+X-P2NwdY4oPMuXrr51awafA@mail.gmail.com/
[2] https://lore.kernel.org/lkml/30fd0e5f2156665c713cf191c5fea9a5548360c0.1609926856.git.viresh.kumar@linaro.org/
next prev parent reply other threads:[~2021-02-06 0:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 7:24 [PATCH V7 0/6] dt: build overlays Viresh Kumar
2021-01-29 7:24 ` [PATCH V7 1/6] scripts: dtc: Fetch fdtoverlay.c from external DTC project Viresh Kumar
2021-01-29 7:24 ` [PATCH V7 2/6] scripts: dtc: Build fdtoverlay tool Viresh Kumar
2021-01-29 7:24 ` [PATCH V7 3/6] scripts: dtc: Remove the unused fdtdump.c file Viresh Kumar
2021-01-29 7:24 ` [PATCH V7 4/6] kbuild: Add support to build overlays (%.dtbo) Viresh Kumar
2021-02-05 9:02 ` Geert Uytterhoeven
2021-02-05 9:25 ` Viresh Kumar
2021-02-05 9:41 ` Geert Uytterhoeven
2021-02-05 9:55 ` Viresh Kumar [this message]
2021-02-05 10:17 ` Geert Uytterhoeven
2021-02-05 21:08 ` Rob Herring
2021-02-06 11:03 ` Geert Uytterhoeven
2021-02-25 1:32 ` Frank Rowand
2021-03-03 5:21 ` Viresh Kumar
2021-03-03 10:44 ` Geert Uytterhoeven
2021-03-03 10:54 ` Viresh Kumar
2021-02-06 7:28 ` David Gibson
2021-01-29 7:24 ` [PATCH V7 5/6] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi Viresh Kumar
2021-02-18 21:02 ` Frank Rowand
2021-02-19 5:20 ` Frank Rowand
2021-02-19 5:28 ` Viresh Kumar
2021-01-29 7:24 ` [PATCH V7 6/6] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar
2021-02-04 1:54 ` Rob Herring
2021-02-04 7:41 ` Viresh Kumar
2021-02-08 11:18 ` Viresh Kumar
2021-02-08 14:21 ` Rob Herring
2021-02-09 4:04 ` Viresh Kumar
2021-02-09 10:10 ` Viresh Kumar
2021-02-16 10:39 ` Viresh Kumar
2021-02-04 15:58 ` [PATCH V7 0/6] dt: build overlays Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205095545.woevnkxg3ar7ctys@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=anmar.oueja@linaro.org \
--cc=bill.mills@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).