From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A88FC433E0 for ; Fri, 5 Feb 2021 11:50:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4AEE64E56 for ; Fri, 5 Feb 2021 11:50:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231378AbhBELuJ (ORCPT ); Fri, 5 Feb 2021 06:50:09 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:56120 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231686AbhBELpn (ORCPT ); Fri, 5 Feb 2021 06:45:43 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1l7zXP-0001cS-NS; Fri, 05 Feb 2021 22:44:36 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 05 Feb 2021 22:44:35 +1100 Date: Fri, 5 Feb 2021 22:44:35 +1100 From: Herbert Xu To: Longfang Liu Cc: wangzhou1@hisilicon.com, xuzaibo@huawei.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Ard Biesheuvel Subject: Re: [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error Message-ID: <20210205114435.GA17031@gondor.apana.org.au> References: <1612519857-30714-1-git-send-email-liulongfang@huawei.com> <1612519857-30714-4-git-send-email-liulongfang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1612519857-30714-4-git-send-email-liulongfang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 06:10:57PM +0800, Longfang Liu wrote: > If this configuration item is not turned on, > the allocation of crypto_tfm will fail when > the shash algorithm calculates the hash > through the software. > > Signed-off-by: Longfang Liu > --- > arch/arm64/configs/defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 8383016..7cfc9b6 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -117,7 +117,7 @@ CONFIG_KVM=y > CONFIG_ARM64_CRYPTO=y > CONFIG_CRYPTO_SHA1_ARM64_CE=y > CONFIG_CRYPTO_SHA2_ARM64_CE=y > -CONFIG_CRYPTO_SHA512_ARM64_CE=m > +CONFIG_CRYPTO_SHA512_ARM64_CE=y If this is truly needed then it should be enabled through Kconfig. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt