From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D760C433DB for ; Fri, 5 Feb 2021 12:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51D8664FCA for ; Fri, 5 Feb 2021 12:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231791AbhBEMHk (ORCPT ); Fri, 5 Feb 2021 07:07:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230111AbhBEMEa (ORCPT ); Fri, 5 Feb 2021 07:04:30 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C99AFC061786 for ; Fri, 5 Feb 2021 04:03:38 -0800 (PST) Received: from zn.tnic (p200300ec2f0bad00ff9d6d5b91facfca.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:ad00:ff9d:6d5b:91fa:cfca]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 73CF71EC030F; Fri, 5 Feb 2021 13:02:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1612526566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sKxM3ZrxvQUzR3JycrEdrI/8jyBLCDgk1CkoAaj5SSs=; b=K+PS6/Tv06ySifmoob52mksbJAOoDnXEsKabYYxN4cmyEKQnZWdctsyNElrgB6F3q7aQuO bsBF8ATPCII8npUABzL4lzW90E7iftEzyOPLFma3RwpSpJEBwONY+ltauYjQ0n+R0pC+e+ RD/SCEo+UXB3JDEo3u9aHgkez7snj5o= Date: Fri, 5 Feb 2021 13:02:44 +0100 From: Borislav Petkov To: Thomas Gleixner Cc: LKML , x86@kernel.org, Josh Poimboeuf , Kees Cook Subject: Re: [patch 01/12] x86/entry: Fix instrumentation annotation Message-ID: <20210205120244.GE17488@zn.tnic> References: <20210204204903.350275743@linutronix.de> <20210204211154.091926005@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210204211154.091926005@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2021 at 09:49:04PM +0100, Thomas Gleixner wrote: > Embracing a callout into instrumentation_begin() / instrumentation_begin() > does not really make sense. Make the latter instrumentation_end(). > > Signed-off-by: Thomas Gleixner > --- > arch/x86/entry/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/x86/entry/common.c > +++ b/arch/x86/entry/common.c > @@ -270,7 +270,7 @@ static void __xen_pv_evtchn_do_upcall(vo > > instrumentation_begin(); > run_on_irqstack_cond(__xen_pv_evtchn_do_upcall, regs); > - instrumentation_begin(); > + instrumentation_end(); > > set_irq_regs(old_regs); Cc: ? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette