From: David Sterba <dsterba@suse.cz> To: Ira Weiny <ira.weiny@intel.com> Cc: dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, Miao Xie <miaox@cn.fujitsu.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs/btrfs: Fix raid6 qstripe kmap'ing Date: Fri, 5 Feb 2021 16:34:41 +0100 [thread overview] Message-ID: <20210205153441.GK1993@twin.jikos.cz> (raw) In-Reply-To: <20210205035236.GB5033@iweiny-DESK2.sc.intel.com> On Thu, Feb 04, 2021 at 07:52:36PM -0800, Ira Weiny wrote: > On Thu, Feb 04, 2021 at 04:26:08PM +0100, David Sterba wrote: > > On Wed, Feb 03, 2021 at 04:56:48PM +0100, David Sterba wrote: > > > On Wed, Jan 27, 2021 at 10:15:03PM -0800, ira.weiny@intel.com wrote: > > > > From: Ira Weiny <ira.weiny@intel.com> > > > Changelog is good, thanks. I've added stable tags as the missing unmap > > > is a potential problem. > > > > There are lots of tests faling, stack traces like below. I haven't seen > > anything obvious in the patch so that needs a closer look and for the > > time being I can't add the patch to for-next. > > :-( > > I think I may have been off by 1 on the raid6 kmap... > > Something like this should fix it... > > diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c > index b8a39dad0f00..dbf52f1a379d 100644 > --- a/fs/btrfs/raid56.c > +++ b/fs/btrfs/raid56.c > @@ -2370,7 +2370,7 @@ static noinline void finish_parity_scrub(struct btrfs_raid_bio *rbio, > goto cleanup; > } > SetPageUptodate(q_page); > - pointers[rbio->real_stripes] = kmap(q_page); > + pointers[rbio->real_stripes - 1] = kmap(q_page); Oh right and tests agree it works. > } > > atomic_set(&rbio->error, 0); > > Let me roll a new version. No need to, I'll fold the fixup. Thanks.
next prev parent reply other threads:[~2021-02-05 23:51 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-28 6:15 ira.weiny 2021-02-03 15:56 ` David Sterba 2021-02-04 15:26 ` David Sterba 2021-02-05 3:52 ` Ira Weiny 2021-02-05 15:34 ` David Sterba [this message] 2021-02-05 16:39 ` Ira Weiny
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210205153441.GK1993@twin.jikos.cz \ --to=dsterba@suse.cz \ --cc=clm@fb.com \ --cc=dsterba@suse.com \ --cc=ira.weiny@intel.com \ --cc=josef@toxicpanda.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=miaox@cn.fujitsu.com \ --subject='Re: [PATCH] fs/btrfs: Fix raid6 qstripe kmap'\''ing' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).