From: Krzysztof Kozlowski <krzk@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Oleksij Rempel <linux@rempel-privat.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/15] dt-bindings: i2c: imx: update schema to align with original binding
Date: Sat, 6 Feb 2021 12:27:23 +0100 [thread overview]
Message-ID: <20210206112723.zmpdxaqlgu6vzmm2@kozik-lap> (raw)
In-Reply-To: <20210205234734.3397-3-leoyang.li@nxp.com>
On Fri, Feb 05, 2021 at 05:47:21PM -0600, Li Yang wrote:
> Layerscape SoCs doesn't use ipg as clock name. Remove the clock name
> requirement in the schema. Also the original binding doesn't enforce
> the order of "tx" and "rx" in dma-names. Both orders are used
> extensively in existing dtses, update the schema to allow both.
>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> index f23966b0d6c6..57237b0b7d89 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> @@ -54,20 +54,19 @@ properties:
> maxItems: 1
>
> clock-names:
> - const: ipg
> + maxItems: 1
No, for other SoCs the clock is I think required, so it should be there.
Add an allof-if statements to require it on specific compatibles and
skip on others.
>
> clock-frequency:
> enum: [ 100000, 400000 ]
>
> dmas:
> - items:
> - - description: DMA controller phandle and request line for RX
> - - description: DMA controller phandle and request line for TX
> + minItems: 2
> + maxItems: 2
>
> dma-names:
> items:
> - - const: rx
> - - const: tx
> + - enum: [ "rx", "tx" ]
> + - enum: [ "tx", "rx" ]
No, the order should be enforced. That was a generic recommendation from
Rob.
Also, I don't get the what does it mean "the original binding" in commit
msg. This is the original binding. Upstream. Mainline.
If your DTSes have different order, please adjust them, not the binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-02-06 11:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 23:47 [PATCH 00/15] Cleanup of LS1021a device trees Li Yang
2021-02-05 23:47 ` [PATCH 01/15] dt-bindings: arm: fsl: add ls1021a-tsn board Li Yang
2021-02-06 11:22 ` Krzysztof Kozlowski
2021-02-11 0:02 ` Rob Herring
2021-02-05 23:47 ` [PATCH 02/15] dt-bindings: i2c: imx: update schema to align with original binding Li Yang
2021-02-06 11:27 ` Krzysztof Kozlowski [this message]
2021-02-05 23:47 ` [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema Li Yang
2021-02-06 11:37 ` Krzysztof Kozlowski
2021-02-08 16:55 ` Rob Herring
2021-02-08 17:07 ` Leo Li
2021-02-08 18:21 ` Rob Herring
2021-02-08 23:25 ` Leo Li
2021-02-05 23:47 ` [PATCH 04/15] ARM: dts: ls1021a: change to use SPDX identifiers Li Yang
2021-02-06 11:42 ` Krzysztof Kozlowski
2021-02-05 23:47 ` [PATCH 05/15] ARM: dts: ls1021a-qds: Add node for QSPI flash Li Yang
2021-02-05 23:47 ` [PATCH 06/15] ARM: dts: ls1021a: update pcie nodes for dt-schema check Li Yang
2021-02-05 23:47 ` [PATCH 07/15] ARM: dts: ls1021a: fix board compatible to follow binding schema Li Yang
2021-02-05 23:47 ` [PATCH 08/15] ARM: dts: ls1021a: breakup long values in thermal node Li Yang
2021-02-05 23:47 ` [PATCH 09/15] ARM: dts: ls1021a: fix ifc node to follow binding schema Li Yang
2021-02-05 23:47 ` [PATCH 10/15] ARM: dts: ls1021a: remove regulators simple-bus Li Yang
2021-02-05 23:47 ` [PATCH 11/15] ARM: dts: ls1021a: fix memory node for schema check Li Yang
2021-02-05 23:47 ` [PATCH 12/15] ARM: dts: ls1021a: add #dma-cells to qdma node Li Yang
2021-02-05 23:47 ` [PATCH 13/15] ARM: dts: ls1021a: add #power-domain-cells for power-controller node Li Yang
2021-02-05 23:47 ` [PATCH 14/15] ARM: dts: ls1021a-qds: change fpga to simple-mfd device Li Yang
2021-02-05 23:47 ` [PATCH 15/15] ARM: dts: ls1021a-tsn: remove undocumented property "position" from mma8452 node Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210206112723.zmpdxaqlgu6vzmm2@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).