* [PATCH net-next] cfg80211: remove unused callback
@ 2021-02-06 12:29 Matteo Croce
2021-02-06 19:46 ` Matteo Croce
0 siblings, 1 reply; 2+ messages in thread
From: Matteo Croce @ 2021-02-06 12:29 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, Johannes Berg, David S. Miller, Jakub Kicinski
From: Matteo Croce <mcroce@microsoft.com>
The ieee80211 class registers a callback which actually does nothing.
Given that the callback is optional, and all its accesses are protected
by a NULL check, remove it entirely.
Signed-off-by: Matteo Croce <mcroce@microsoft.com>
---
net/wireless/sysfs.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/net/wireless/sysfs.c b/net/wireless/sysfs.c
index 3ac1f48195d2..41cb4d565149 100644
--- a/net/wireless/sysfs.c
+++ b/net/wireless/sysfs.c
@@ -81,12 +81,6 @@ static void wiphy_dev_release(struct device *dev)
cfg80211_dev_free(rdev);
}
-static int wiphy_uevent(struct device *dev, struct kobj_uevent_env *env)
-{
- /* TODO, we probably need stuff here */
- return 0;
-}
-
#ifdef CONFIG_PM_SLEEP
static void cfg80211_leave_all(struct cfg80211_registered_device *rdev)
{
@@ -157,7 +151,6 @@ struct class ieee80211_class = {
.owner = THIS_MODULE,
.dev_release = wiphy_dev_release,
.dev_groups = ieee80211_groups,
- .dev_uevent = wiphy_uevent,
.pm = WIPHY_PM_OPS,
.ns_type = &net_ns_type_operations,
.namespace = wiphy_namespace,
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] cfg80211: remove unused callback
2021-02-06 12:29 [PATCH net-next] cfg80211: remove unused callback Matteo Croce
@ 2021-02-06 19:46 ` Matteo Croce
0 siblings, 0 replies; 2+ messages in thread
From: Matteo Croce @ 2021-02-06 19:46 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, Johannes Berg, David S. Miller, Jakub Kicinski
On Sat, Feb 6, 2021 at 1:29 PM Matteo Croce <mcroce@linux.microsoft.com> wrote:
>
> From: Matteo Croce <mcroce@microsoft.com>
>
> The ieee80211 class registers a callback which actually does nothing.
> Given that the callback is optional, and all its accesses are protected
> by a NULL check, remove it entirely.
>
> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
> ---
I just noticed that I forgot to cc linux-wireless, I will resend it
--
per aspera ad upstream
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-06 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-06 12:29 [PATCH net-next] cfg80211: remove unused callback Matteo Croce
2021-02-06 19:46 ` Matteo Croce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).