From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABCD5C433E0 for ; Sun, 7 Feb 2021 21:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CCFA64E3F for ; Sun, 7 Feb 2021 21:12:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbhBGVM3 (ORCPT ); Sun, 7 Feb 2021 16:12:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:48518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbhBGVM0 (ORCPT ); Sun, 7 Feb 2021 16:12:26 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B7EB964E35; Sun, 7 Feb 2021 21:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612732306; bh=+XdaDQexeZGU5UTGEhbJS1Xe1ktEJS5gwq1IiBErUQ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SjqD7IjDs/KREf+vNjGLvZa0iRykgVeh2eA6BRJ9FfUnxcsUeKqgd9R+ShT7+aPTI +PFC8QFzfiHCbRS/JSc3iudvGcOkB5Uq/Lp2Ry+OqmxgAjp/U88uk1q5mJagj+bd5T M8Xp2j58dzcuCoxtX9n/e9QRXEKtqlTZHAUpyWEA= Date: Sun, 7 Feb 2021 13:11:45 -0800 From: Andrew Morton To: Jakub Kicinski Cc: NeilBrown , Alexander Viro , Jonathan Corbet , Xin Long , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Ingo Molnar , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "David S. Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 0/3] Fix some seq_file users that were recently broken Message-Id: <20210207131145.ea12b9944c54ad2f10932bc3@linux-foundation.org> In-Reply-To: <20210206142924.2bfc3cf5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <161248518659.21478.2484341937387294998.stgit@noble1> <20210205143550.58d3530918459eafa918ad0c@linux-foundation.org> <20210206142924.2bfc3cf5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Feb 2021 14:29:24 -0800 Jakub Kicinski wrote: > On Fri, 5 Feb 2021 14:35:50 -0800 Andrew Morton wrote: > > On Fri, 05 Feb 2021 11:36:30 +1100 NeilBrown wrote: > > > > > A recent change to seq_file broke some users which were using seq_file > > > in a non-"standard" way ... though the "standard" isn't documented, so > > > they can be excused. The result is a possible leak - of memory in one > > > case, of references to a 'transport' in the other. > > > > > > These three patches: > > > 1/ document and explain the problem > > > 2/ fix the problem user in x86 > > > 3/ fix the problem user in net/sctp > > > > 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and > > interface") was August 2018, so I don't think "recent" applies here? > > > > I didn't look closely, but it appears that the sctp procfs file is > > world-readable. So we gave unprivileged userspace the ability to leak > > kernel memory? > > > > So I'm thinking that we aim for 5.12-rc1 on all three patches with a cc:stable? > > I'd rather take the sctp patch sooner, we'll send another batch > of networking fixes for 5.11, anyway. Would that be okay with you? Sure.