From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB76C433DB for ; Tue, 9 Feb 2021 12:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E17A564E50 for ; Tue, 9 Feb 2021 12:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230300AbhBIMlb (ORCPT ); Tue, 9 Feb 2021 07:41:31 -0500 Received: from elvis.franken.de ([193.175.24.41]:36517 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230224AbhBIMj7 (ORCPT ); Tue, 9 Feb 2021 07:39:59 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l9SIV-0003IE-02; Tue, 09 Feb 2021 13:39:15 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 628E6C0DBF; Tue, 9 Feb 2021 13:34:55 +0100 (CET) Date: Tue, 9 Feb 2021 13:34:55 +0100 From: Thomas Bogendoerfer To: Jinyang He Cc: Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] MIPS: relocatable: Use __kaslr_offset in show_kernel_relocation Message-ID: <20210209123455.GB11264@alpha.franken.de> References: <1612519882-16480-1-git-send-email-hejinyang@loongson.cn> <1612519882-16480-2-git-send-email-hejinyang@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1612519882-16480-2-git-send-email-hejinyang@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 06:11:22PM +0800, Jinyang He wrote: > The type of the VMLINUX_LOAD_ADDRESS macro is the (unsigned long long) > in 32bits kernel but (unsigned long) in the 64-bit kernel. Although there > is no error here, avoid using it to calculate kaslr_offset. > > Signed-off-by: Jinyang He > --- > arch/mips/kernel/relocate.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]