From: Jason Gunthorpe <jgg@ziepe.ca>
To: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
peterhuewe@gmx.de, stefanb@linux.vnet.ibm.com,
stable@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] tpm: in tpm2_del_space check if ops pointer is still valid
Date: Tue, 9 Feb 2021 09:36:53 -0400 [thread overview]
Message-ID: <20210209133653.GC4718@ziepe.ca> (raw)
In-Reply-To: <08ce58ab-3513-5d98-16a5-b197276f6bce@kunbus.com>
On Tue, Feb 09, 2021 at 12:52:17PM +0100, Lino Sanfilippo wrote:
> > @@ -640,8 +643,10 @@ void tpm_chip_unregister(struct tpm_chip *chip)
> > if (IS_ENABLED(CONFIG_HW_RANDOM_TPM))
> > hwrng_unregister(&chip->hwrng);
> > tpm_bios_log_teardown(chip);
> > - if (chip->flags & TPM_CHIP_FLAG_TPM2)
> > + if (chip->flags & TPM_CHIP_FLAG_TPM2) {
> > cdev_device_del(&chip->cdevs, &chip->devs);
> > + put_device(&chip->devs);
> > + }
> > tpm_del_char_device(chip);
> > }
> > EXPORT_SYMBOL_GPL(tpm_chip_unregister);
> >
>
> I tested the solution you scetched and it fixes the issue for me. Will you send a (real) patch for this?
No, feel free to bundle this up with any fixes needed and send it with
a Signed-off-by from both of us
I did it pretty fast so it will need a careful read that there isn't a
typo
Thanks,
Jason
next prev parent reply other threads:[~2021-02-09 13:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 23:50 [PATCH v3 0/2] TPM fixes Lino Sanfilippo
2021-02-04 23:50 ` [PATCH v3 1/2] tpm: fix reference counting for struct tpm_chip Lino Sanfilippo
2021-02-05 0:46 ` Stefan Berger
2021-02-05 1:44 ` Stefan Berger
2021-02-05 2:01 ` James Bottomley
2021-02-05 10:52 ` Lino Sanfilippo
2021-02-05 13:29 ` Stefan Berger
2021-02-05 10:34 ` Lino Sanfilippo
2021-02-05 6:50 ` Greg KH
2021-02-05 13:05 ` Jason Gunthorpe
2021-02-05 14:55 ` Lino Sanfilippo
2021-02-05 15:15 ` Jason Gunthorpe
2021-02-05 15:50 ` Lino Sanfilippo
2021-02-05 15:58 ` Jason Gunthorpe
2021-02-05 21:50 ` Lino Sanfilippo
2021-02-06 0:39 ` Jason Gunthorpe
2021-02-04 23:50 ` [PATCH v3 2/2] tpm: in tpm2_del_space check if ops pointer is still valid Lino Sanfilippo
2021-02-05 0:34 ` James Bottomley
2021-02-05 2:18 ` Jarkko Sakkinen
2021-02-05 16:48 ` James Bottomley
2021-02-05 17:25 ` Jason Gunthorpe
2021-02-05 17:54 ` James Bottomley
2021-02-06 1:02 ` Jason Gunthorpe
2021-02-06 1:08 ` James Bottomley
2021-02-06 1:34 ` Jason Gunthorpe
2021-02-09 11:52 ` Lino Sanfilippo
2021-02-09 13:36 ` Jason Gunthorpe [this message]
2021-02-09 13:39 ` Lino Sanfilippo
2021-02-12 11:02 ` Jarkko Sakkinen
2021-02-12 10:59 ` Jarkko Sakkinen
2021-02-14 17:22 ` Lino Sanfilippo
2021-02-05 10:30 ` Lino Sanfilippo
2021-03-06 16:07 ` Lino Sanfilippo
2021-02-05 6:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209133653.GC4718@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=James.Bottomley@HansenPartnership.com \
--cc=LinoSanfilippo@gmx.de \
--cc=jarkko@kernel.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).